review fix: Object[]::new references resolution #1945
Conversation
surli
changed the title
|
The proposed solution is far from being perfect but it's a first step. I propose that before improving it further we define first a better test contract. |
|
|
||
| @Test | ||
| public void testPbWithStream() { | ||
| // contract: array constructor references are well represented |
There was a problem hiding this comment.
add assert on type of element (instanceof InvisibleArrayConstructorImpl)?
add assert on toString of element?
| * String[]::new | ||
| * </pre> | ||
| */ | ||
| public class InvisibleArrayConstructor<T> extends CtConstructorImpl<T> { |
There was a problem hiding this comment.
By convention, should end by Impl: InvisibleArrayConstructorImpl, and should be in spoon.support.reflect.declaration (all implementation classes are in spoon.support)
There was a problem hiding this comment.
It is in spoon.support. I will rename it.
|
Thanks @surli. LGTM, see comments. |
|
API changes: 1 (Detected by Revapi) Old API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-20180613.225605-139 / New API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-SNAPSHOT
|
|
For me it's ready again. |
|
Thanks Simon! |
fix #1883