-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP doc: Differences between JavaParser and Spoon #2744
Conversation
Where is the page? Well, I do not feel you need our authorization to write on the Spoon's website :) However, as I wrote in the other documentation, I think it is hard to have something that is totally unbiased and "approved" by both sides. For sure anyone can feel free to write their own vision on the comparison. |
sure ;-) It is reaction on your
So you are welcome here to write your vision or at least link to your visions in JavaParser documentation, so it is no more our fail that information provided about JavaParser are wrong. |
Good point. I will review it and give you feedback based on my opinion.
Thank you for this opportunity
…On Sun, 4 Nov 2018 at 12:09, Pavel Vojtechovsky ***@***.***> wrote:
Well, I do not feel you need our authorization to write on the Spoon's
website
sure ;-) It is reaction on your
Well, I am a JavaParser contributor and it seems to me that some
statements about JavaParser are wrong.
So you are welcome here to write your vision or at least link to your
visions in JavaParser documentation, so it is no more our fail that
information provided about JavaParser are wrong.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2744 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAazJq09v3LVD5HHUOwHdyPW7yyTxfVBks5ursrXgaJpZM4YNPfv>
.
--
Website at https://tomassetti.me
GitHub https://github.com/ftomassetti
|
Yes, definitely. Thanks for this great initiative, full of respect and constructive discussions. |
Do you support lexical preservation? I mean, can someone parse some code, modify it using the library, and printing it back with the original formatting? |
Yes, we call it |
@ftomassetti if I did it in the way which is incorrect, then it was not intentional. Let me know with another comment or PR on this PR. |
Hi, I wanted just to let you know that in the end we finally published the article on Spoon. You can find it here: How and Why to Analyze, Generate and Transform Java Code Using Spoon |
Awesome, thanks Federico! do we have the right to respond :-)? |
Sure, please feel free to write me an email at any time to correct/update things or just add your view |
I shared with you here precisely for that. |
Cool! About the technical content:
About the philosophy (this is where your post hurt a little bit, but no bad feelings, don't worry :-):
(+typo "hilosophy" -> "philosophy") |
I realized I did not re-read properly the final part of the article and some notes ended up sounding much harsher than I originally intended. Sorry abou that. I also realize that sometimes I could have not used the best approach because of my ignorance (i.e., the lack of usage of patterns" |
Thank you about the typo, I fixed it |
Really cool!
In your post, could you remove the last paragraph of 'Philosophy' about dependencies, which is
incorrect (the problem was a mistake for a specific version, it's fixed).
Thanks!
…--Martin
|
@monperrus I added a note at the end of the article to explain you fixed that and you are discussing changing the license |
Thanks. Simply removing the paragraph would be less misleading for the reader. By reading this
section, it sounds like the dependency problem has always been there and is still there, which is
incorrect.
|
I would propose to close this PR then. |
Here is first raw draft of page which lists differences between Spoon and JavaParser.
@monperrus, ... AND @ftomassetti, ... do you agree to have such (after content is agreed by both sides) documentation page as part of Spoon web?
if both sides agree, then please contribute your content and fixes of my bad English ;-)
Note: @monperrus I am not sure how to link new docu to spoon web menus.
The intention is that both sides can later contribute content here so it is as more fair then #1303.
WDYT?