Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate NewClassTest to JUnit 5 #4490

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

MartinWitt
Copy link
Collaborator

#3919

Change Log

The following bad smells are refactored:

Junit4-@before

The JUnit 4 @Before annotation should be replaced with JUnit 5 @BeforeEach annotation.

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4Assertion

The JUnit4 assertion should be replaced with JUnit5 Assertions.

The following has changed in the code:

JUnit4-@test

  • Replaced junit 4 test annotation with junit 5 test annotation in testNewClassWithObjectClass
  • Replaced junit 4 test annotation with junit 5 test annotation in testNewClassWithInterface
  • Replaced junit 4 test annotation with junit 5 test annotation in testNewClassWithInterfaceGeneric
  • Replaced junit 4 test annotation with junit 5 test annotation in testNewClassInterfaceWithParameters
  • Replaced junit 4 test annotation with junit 5 test annotation in testNewClassInEnumeration
  • Replaced junit 4 test annotation with junit 5 test annotation in testMoreThan9NewClass
  • Replaced junit 4 test annotation with junit 5 test annotation in testCtNewClassInNoClasspath
  • Replaced junit 4 test annotation with junit 5 test annotation in testBadConstructorCallToAnonymousGenericType

Junit4-@before

  • Replaced @Before annotation with @BeforeEach at method setUp

JUnit4Assertion

  • Transformed junit4 assert to junit 5 assertion in testNewClassWithObjectClass
  • Transformed junit4 assert to junit 5 assertion in testNewClassWithInterface
  • Transformed junit4 assert to junit 5 assertion in testNewClassWithInterfaceGeneric
  • Transformed junit4 assert to junit 5 assertion in testNewClassInEnumeration
  • Transformed junit4 assert to junit 5 assertion in assertSuperClass
  • Transformed junit4 assert to junit 5 assertion in assertSuperInterface
  • Transformed junit4 assert to junit 5 assertion in assertIsAnonymous
  • Transformed junit4 assert to junit 5 assertion in assertHasParameters
  • Transformed junit4 assert to junit 5 assertion in assertIsConstructor
  • Transformed junit4 assert to junit 5 assertion in assertType
  • Transformed junit4 assert to junit 5 assertion in testMoreThan9NewClass
  • Transformed junit4 assert to junit 5 assertion in testCtNewClassInNoClasspath

 The following has changed in the code:
Replaced @before annotation with @beforeeach at method setUp
Replaced junit 4 test annotation with junit 5 test annotation in testNewClassWithObjectClass
Replaced junit 4 test annotation with junit 5 test annotation in testNewClassWithInterface
Replaced junit 4 test annotation with junit 5 test annotation in testNewClassWithInterfaceGeneric
Replaced junit 4 test annotation with junit 5 test annotation in testNewClassInterfaceWithParameters
Replaced junit 4 test annotation with junit 5 test annotation in testNewClassInEnumeration
Replaced junit 4 test annotation with junit 5 test annotation in testMoreThan9NewClass
Replaced junit 4 test annotation with junit 5 test annotation in testCtNewClassInNoClasspath
Replaced junit 4 test annotation with junit 5 test annotation in testBadConstructorCallToAnonymousGenericType
Transformed junit4 assert to junit 5 assertion in testNewClassWithObjectClass
Transformed junit4 assert to junit 5 assertion in testNewClassWithInterface
Transformed junit4 assert to junit 5 assertion in testNewClassWithInterfaceGeneric
Transformed junit4 assert to junit 5 assertion in testNewClassInEnumeration
Transformed junit4 assert to junit 5 assertion in assertSuperClass
Transformed junit4 assert to junit 5 assertion in assertSuperInterface
Transformed junit4 assert to junit 5 assertion in assertIsAnonymous
Transformed junit4 assert to junit 5 assertion in assertHasParameters
Transformed junit4 assert to junit 5 assertion in assertIsConstructor
Transformed junit4 assert to junit 5 assertion in assertType
Transformed junit4 assert to junit 5 assertion in testMoreThan9NewClass
Transformed junit4 assert to junit 5 assertion in testCtNewClassInNoClasspath
Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slarse slarse merged commit fda81f1 into INRIA:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants