test: migrate VariableReferencesTest to JUnit 5 #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following has changed in the code: Replaced @before annotation with @beforeeach at method setup Replaced junit 4 test annotation with junit 5 test annotation in testCheckModelConsistency Replaced junit 4 test annotation with junit 5 test annotation in testCatchVariableReferenceFunction Replaced junit 4 test annotation with junit 5 test annotation in testLocalVariableReferenceFunction Replaced junit 4 test annotation with junit 5 test annotation in testParameterReferenceFunction Replaced junit 4 test annotation with junit 5 test annotation in testVariableReferenceFunction Replaced junit 4 test annotation with junit 5 test annotation in testVariableScopeFunction Replaced junit 4 test annotation with junit 5 test annotation in testFieldScopeFunction Replaced junit 4 test annotation with junit 5 test annotation in testLocalVariableReferenceDeclarationFunction Replaced junit 4 test annotation with junit 5 test annotation in testPotentialVariableAccessFromStaticMethod Transformed junit4 assert to junit 5 assertion in testCheckModelConsistency Transformed junit4 assert to junit 5 assertion in testVariableScopeFunction Transformed junit4 assert to junit 5 assertion in testFieldScopeFunction Transformed junit4 assert to junit 5 assertion in testLocalVariableReferenceDeclarationFunction Transformed junit4 assert to junit 5 assertion in checkVariableAccess Transformed junit4 assert to junit 5 assertion in getLiteralValue Transformed junit4 assert to junit 5 assertion in testPotentialVariableAccessFromStaticMethod
slarse
suggested changes
Jan 14, 2022
| assertEquals("Only these keys were found: "+context.unique.keySet(), context.maxKey, context.unique.size()); | ||
| assertEquals("AllLocalVars#maxValue must be equal to maximum value number ", (int)getLiteralValue((CtVariable)modelClass.filterChildren(new NamedElementFilter<>(CtVariable.class,"maxValue")).first()), context.maxKey); | ||
| assertEquals(context.maxKey, context.unique.size(), "Only these keys were found: " + context.unique.keySet()); | ||
| assertEquals(((int) (getLiteralValue(((CtVariable) (modelClass.filterChildren(new NamedElementFilter<>(CtVariable.class, "maxValue")).first()))))), context.maxKey, "AllLocalVars#maxValue must be equal to maximum value number "); |
There was a problem hiding this comment.
Ugh, sniper printing of casts at work here (see #3809 (comment)). Could you manually remove the redundant parentheses?
| assertNotNull("The declaration of variable "+varRef.getSimpleName()+" in "+getParentMethodName(varRef)+" on line "+var.getPosition().getLine()+" with value "+getVariableReferenceValue(varRef)+" was not found", var); | ||
| assertEquals("CtLocalVariableReference#getDeclaration returned wrong declaration in "+getParentMethodName(varRef), getVariableReferenceValue(varRef), (int)getLiteralValue(var)); | ||
| assertNotNull(var, "The declaration of variable " + varRef.getSimpleName() + " in " + getParentMethodName(varRef) + " on line " + var.getPosition().getLine() + " with value " + getVariableReferenceValue(varRef) + " was not found"); | ||
| assertEquals(getVariableReferenceValue(varRef), ((int) (getLiteralValue(var))), "CtLocalVariableReference#getDeclaration returned wrong declaration in " + getParentMethodName(varRef)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3919
Change Log
The following bad smells are refactored:
Junit4-@before
The JUnit 4
@Beforeannotation should be replaced with JUnit 5@BeforeEachannotation.JUnit4-@test
The JUnit 4
@Testannotation should be replaced with JUnit 5@Testannotation.JUnit4Assertion
The JUnit4 assertion should be replaced with JUnit5 Assertions.
The following has changed in the code:
JUnit4-@test
testCheckModelConsistencytestCatchVariableReferenceFunctiontestLocalVariableReferenceFunctiontestParameterReferenceFunctiontestVariableReferenceFunctiontestVariableScopeFunctiontestFieldScopeFunctiontestLocalVariableReferenceDeclarationFunctiontestPotentialVariableAccessFromStaticMethodJunit4-@before
@Beforeannotation with@BeforeEachat methodsetupJUnit4Assertion
checkKeytestCheckModelConsistencytestVariableScopeFunctiontestFieldScopeFunctiontestLocalVariableReferenceDeclarationFunctioncheckVariableAccessgetLiteralValuetestPotentialVariableAccessFromStaticMethod