Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate PrinterTest JUnit 5 #4499

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

MartinWitt
Copy link
Collaborator

#3919

Change Log

The following bad smells are refactored:

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4Assertion

The JUnit4 assertion should be replaced with JUnit5 Assertions.

The following has changed in the code:

JUnit4-@test

  • Replaced junit 4 test annotation with junit 5 test annotation in testPrettyPrinter
  • Replaced junit 4 test annotation with junit 5 test annotation in testChangeAutoImportModeWorks
  • Replaced junit 4 test annotation with junit 5 test annotation in testFQNModeWriteFQNConstructorInCtVisitor
  • Replaced junit 4 test annotation with junit 5 test annotation in testAutoimportModeDontImportUselessStatic
  • Replaced junit 4 test annotation with junit 5 test annotation in testAutoimportModeDontImportUselessStaticNoClassPath
  • Replaced junit 4 test annotation with junit 5 test annotation in testUnresolvedImportStaticNoClassPath
  • Replaced junit 4 test annotation with junit 5 test annotation in testUnresolvedNoClassPath
  • Replaced junit 4 test annotation with junit 5 test annotation in testRuleCanBeBuild
  • Replaced junit 4 test annotation with junit 5 test annotation in testLambdaCanBeBuild
  • Replaced junit 4 test annotation with junit 5 test annotation in testJDTBatchCompilerCanBeBuild
  • Replaced junit 4 test annotation with junit 5 test annotation in testPrintingOfOrphanFieldReference
  • Replaced junit 4 test annotation with junit 5 test annotation in testPrinterTokenListener
  • Replaced junit 4 test annotation with junit 5 test annotation in testListPrinter
  • Replaced junit 4 test annotation with junit 5 test annotation in testMethodParentheses
  • Replaced junit 4 test annotation with junit 5 test annotation in testCustomPrettyPrinter
  • Replaced junit 4 test annotation with junit 5 test annotation in testTypeLostPrintingStringClassReference
  • Replaced junit 4 test annotation with junit 5 test annotation in testTypeLostPrintingListClassReference
  • Replaced junit 4 test annotation with junit 5 test annotation in testTypeLostPrintingFQListClassReference

JUnit4Assertion

  • Transformed junit4 assert to junit 5 assertion in testPrettyPrinter
  • Transformed junit4 assert to junit 5 assertion in testChangeAutoImportModeWorks
  • Transformed junit4 assert to junit 5 assertion in testFQNModeWriteFQNConstructorInCtVisitor
  • Transformed junit4 assert to junit 5 assertion in testAutoimportModeDontImportUselessStatic
  • Transformed junit4 assert to junit 5 assertion in testAutoimportModeDontImportUselessStaticNoClassPath
  • Transformed junit4 assert to junit 5 assertion in testUnresolvedImportStaticNoClassPath
  • Transformed junit4 assert to junit 5 assertion in testUnresolvedNoClassPath
  • Transformed junit4 assert to junit 5 assertion in testRuleCanBeBuild
  • Transformed junit4 assert to junit 5 assertion in testJDTBatchCompilerCanBeBuild
  • Transformed junit4 assert to junit 5 assertion in testPrintingOfOrphanFieldReference
  • Transformed junit4 assert to junit 5 assertion in writeSeparator
  • Transformed junit4 assert to junit 5 assertion in writeOperator
  • Transformed junit4 assert to junit 5 assertion in writeLiteral
  • Transformed junit4 assert to junit 5 assertion in writeKeyword
  • Transformed junit4 assert to junit 5 assertion in writeIdentifier
  • Transformed junit4 assert to junit 5 assertion in writeCodeSnippet
  • Transformed junit4 assert to junit 5 assertion in checkRepeatingOfTokens
  • Transformed junit4 assert to junit 5 assertion in testPrinterTokenListener
  • Transformed junit4 assert to junit 5 assertion in checkTokenWhitespace
  • Transformed junit4 assert to junit 5 assertion in testListPrinter
  • Transformed junit4 assert to junit 5 assertion in testMethodParentheses
  • Transformed junit4 assert to junit 5 assertion in testCustomPrettyPrinter
  • Transformed junit4 assert to junit 5 assertion in testTypeLostPrintingStringClassReference
  • Transformed junit4 assert to junit 5 assertion in testTypeLostPrintingListClassReference
  • Transformed junit4 assert to junit 5 assertion in testTypeLostPrintingFQListClassReference

 The following has changed in the code:
Replaced junit 4 test annotation with junit 5 test annotation in testPrettyPrinter
Replaced junit 4 test annotation with junit 5 test annotation in testChangeAutoImportModeWorks
Replaced junit 4 test annotation with junit 5 test annotation in testFQNModeWriteFQNConstructorInCtVisitor
Replaced junit 4 test annotation with junit 5 test annotation in testAutoimportModeDontImportUselessStatic
Replaced junit 4 test annotation with junit 5 test annotation in testAutoimportModeDontImportUselessStaticNoClassPath
Replaced junit 4 test annotation with junit 5 test annotation in testUnresolvedImportStaticNoClassPath
Replaced junit 4 test annotation with junit 5 test annotation in testUnresolvedNoClassPath
Replaced junit 4 test annotation with junit 5 test annotation in testRuleCanBeBuild
Replaced junit 4 test annotation with junit 5 test annotation in testLambdaCanBeBuild
Replaced junit 4 test annotation with junit 5 test annotation in testJDTBatchCompilerCanBeBuild
Replaced junit 4 test annotation with junit 5 test annotation in testPrintingOfOrphanFieldReference
Replaced junit 4 test annotation with junit 5 test annotation in testPrinterTokenListener
Replaced junit 4 test annotation with junit 5 test annotation in testListPrinter
Replaced junit 4 test annotation with junit 5 test annotation in testMethodParentheses
Replaced junit 4 test annotation with junit 5 test annotation in testCustomPrettyPrinter
Replaced junit 4 test annotation with junit 5 test annotation in testTypeLostPrintingStringClassReference
Replaced junit 4 test annotation with junit 5 test annotation in testTypeLostPrintingListClassReference
Replaced junit 4 test annotation with junit 5 test annotation in testTypeLostPrintingFQListClassReference
Transformed junit4 assert to junit 5 assertion in testPrettyPrinter
Transformed junit4 assert to junit 5 assertion in testChangeAutoImportModeWorks
Transformed junit4 assert to junit 5 assertion in testFQNModeWriteFQNConstructorInCtVisitor
Transformed junit4 assert to junit 5 assertion in testAutoimportModeDontImportUselessStatic
Transformed junit4 assert to junit 5 assertion in testAutoimportModeDontImportUselessStaticNoClassPath
Transformed junit4 assert to junit 5 assertion in testUnresolvedImportStaticNoClassPath
Transformed junit4 assert to junit 5 assertion in testUnresolvedNoClassPath
Transformed junit4 assert to junit 5 assertion in testRuleCanBeBuild
Transformed junit4 assert to junit 5 assertion in testJDTBatchCompilerCanBeBuild
Transformed junit4 assert to junit 5 assertion in testPrintingOfOrphanFieldReference
Transformed junit4 assert to junit 5 assertion in testPrinterTokenListener
Transformed junit4 assert to junit 5 assertion in checkTokenWhitespace
Transformed junit4 assert to junit 5 assertion in testListPrinter
Transformed junit4 assert to junit 5 assertion in testMethodParentheses
Transformed junit4 assert to junit 5 assertion in testCustomPrettyPrinter
Transformed junit4 assert to junit 5 assertion in testTypeLostPrintingStringClassReference
Transformed junit4 assert to junit 5 assertion in testTypeLostPrintingListClassReference
Transformed junit4 assert to junit 5 assertion in testTypeLostPrintingFQListClassReference
@slarse slarse merged commit f31e40e into INRIA:master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants