Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate IntercessionTest to JUnit 5 #4534

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

MartinWitt
Copy link
Collaborator

#3919

Change Log

The following bad smells are refactored:

Junit4-@ignore

The JUnit 4 @Ignore annotation should be replaced with JUnit 5 @Disabled annotation.

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4Assertion

The JUnit4 assertion should be replaced with JUnit5 Assertions.

The following has changed in the code:

JUnit4-@test

  • Replaced junit 4 test annotation with junit 5 test annotation in testInsertBegin
  • Replaced junit 4 test annotation with junit 5 test annotation in testInsertEnd
  • Replaced junit 4 test annotation with junit 5 test annotation in testEqualConstructor
  • Replaced junit 4 test annotation with junit 5 test annotation in test_setThrownExpression
  • Replaced junit 4 test annotation with junit 5 test annotation in testInsertIfIntercession
  • Replaced junit 4 test annotation with junit 5 test annotation in testInsertAfter
  • Replaced junit 4 test annotation with junit 5 test annotation in testSettersAreAllGood
  • Replaced junit 4 test annotation with junit 5 test annotation in testResetCollectionInSetters

Junit4-@ignore

  • Replaced @Ignore annotation with @Disabled at method testResetCollectionInSetters

JUnit4Assertion

  • Transformed junit4 assert to junit 5 assertion in testInsertBegin
  • Transformed junit4 assert to junit 5 assertion in testInsertEnd
  • Transformed junit4 assert to junit 5 assertion in testEqualConstructor
  • Transformed junit4 assert to junit 5 assertion in test_setThrownExpression
  • Transformed junit4 assert to junit 5 assertion in testInsertIfIntercession
  • Transformed junit4 assert to junit 5 assertion in testInsertAfter
  • Transformed junit4 assert to junit 5 assertion in testSettersAreAllGood
  • Transformed junit4 assert to junit 5 assertion in process

 The following has changed in the code:
Replaced @ignore annotation with @disabled at method testResetCollectionInSetters
Replaced junit 4 test annotation with junit 5 test annotation in testInsertBegin
Replaced junit 4 test annotation with junit 5 test annotation in testInsertEnd
Replaced junit 4 test annotation with junit 5 test annotation in testEqualConstructor
Replaced junit 4 test annotation with junit 5 test annotation in test_setThrownExpression
Replaced junit 4 test annotation with junit 5 test annotation in testInsertIfIntercession
Replaced junit 4 test annotation with junit 5 test annotation in testInsertAfter
Replaced junit 4 test annotation with junit 5 test annotation in testSettersAreAllGood
Replaced junit 4 test annotation with junit 5 test annotation in testResetCollectionInSetters
Transformed junit4 assert to junit 5 assertion in testInsertBegin
Transformed junit4 assert to junit 5 assertion in testInsertEnd
Transformed junit4 assert to junit 5 assertion in testEqualConstructor
Transformed junit4 assert to junit 5 assertion in test_setThrownExpression
Transformed junit4 assert to junit 5 assertion in testInsertIfIntercession
Transformed junit4 assert to junit 5 assertion in testInsertAfter
Transformed junit4 assert to junit 5 assertion in testSettersAreAllGood
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants