test: migrate TestModule to JUnit 5 #4544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3919
Change Log
The following bad smells are refactored:
ExpectedException
The expected annotation value should be removed from test methods, and replaced with JUnit 5
assertThrows
.JUnit4-@test
The JUnit 4
@Test
annotation should be replaced with JUnit 5@Test
annotation.JUnit4Assertion
The JUnit4 assertion should be replaced with JUnit5 Assertions.
Junit4-@afterclass
The JUnit 4
@AfterClass
annotation should be replaced with JUnit 5@AfterAll
annotation.Junit4-@BeforeClass
The JUnit 4
@BeforeClass
annotation should be replaced with JUnit 5@BeforeAll
annotation.Junit4-@ignore
The JUnit 4
@Ignore
annotation should be replaced with JUnit 5@Disabled
annotation.The following has changed in the code:
Junit4-@BeforeClass
@BeforeClass
annotation with@BeforeAll
at methodsetUp
Junit4-@afterclass
@After
annotation with@AfterEach
at methodtearDown
JUnit4-@test
testCompleteModuleInfoContentNoClasspath
testModuleInfoShouldBeCorrectlyPrettyPrinted
testModuleInfoWithComments
testDirectiveOrders
testGetParentOfRootPackageOfModule
testGetModuleAfterChangingItsName
testModuleNames
testMultipleModulesAndParents
testModuleComplianceLevelException
testModuleOverlappingPackages
Junit4-@ignore
@Ignore
annotation with@Disabled
at methodtestMultipleModulesAndParents
ExpectedException
testModuleComplianceLevelException
JUnit4Assertion
testCompleteModuleInfoContentNoClasspath
testModuleInfoShouldBeCorrectlyPrettyPrinted
testModuleInfoWithComments
testDirectiveOrders
testGetParentOfRootPackageOfModule
testGetModuleAfterChangingItsName
testSimpleModuleCanBeBuilt
testMultipleModulesAndParents
testModuleComplianceLevelException
testModuleOverlappingPackages