test: migrate MethodTest to JUnit 5

[MartinWitt]

#3919

Change Log

The following bad smells are refactored:

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4Assertion

The JUnit4 assertion should be replaced with JUnit5 Assertions.

The following has changed in the code:

JUnit4-@test

• Replaced junit 4 test annotation with junit 5 test annotation in testClone
• Replaced junit 4 test annotation with junit 5 test annotation in testSearchMethodWithGeneric
• Replaced junit 4 test annotation with junit 5 test annotation in testMethodSignature
• Replaced junit 4 test annotation with junit 5 test annotation in testAddSameMethodsTwoTimes
• Replaced junit 4 test annotation with junit 5 test annotation in testGetAllMethods
• Replaced junit 4 test annotation with junit 5 test annotation in testGetAllMethodsAdaptingType
• Replaced junit 4 test annotation with junit 5 test annotation in test_addParameterAt_addsParameterToSpecifiedPosition
• Replaced junit 4 test annotation with junit 5 test annotation in test_addParameterAt_throwsOutOfBoundsException_whenPositionIsOutOfBounds
• Replaced junit 4 test annotation with junit 5 test annotation in test_addFormalCtTypeParameterAt_addsTypeParameterToSpecifiedPosition
• Replaced junit 4 test annotation with junit 5 test annotation in test_addFormalCtTypeParameterAt_throwsOutOfBoundsException_whenPositionIsOutOfBounds

JUnit4Assertion

• Transformed junit4 assert to junit 5 assertion in testClone
• Transformed junit4 assert to junit 5 assertion in testSearchMethodWithGeneric
• Transformed junit4 assert to junit 5 assertion in testMethodSignature
• Transformed junit4 assert to junit 5 assertion in testAddSameMethodsTwoTimes
• Transformed junit4 assert to junit 5 assertion in testGetAllMethods
• Transformed junit4 assert to junit 5 assertion in testGetAllMethodsAdaptingType
• Transformed junit4 assert to junit 5 assertion in test_addParameterAt_throwsOutOfBoundsException_whenPositionIsOutOfBounds
• Transformed junit4 assert to junit 5 assertion in test_addFormalCtTypeParameterAt_throwsOutOfBoundsException_whenPositionIsOutOfBounds

[slarse]

We really need to get the sniper printer to stop reordering the crap out of imports.

[MartinWitt]

We really need to get the sniper printer to stop reordering the crap out of imports.

The reordering is done on my side because I had big problems with missing imports in sniper printing. The spoon import style is more or less

package ...

spoon and non java types

jdk types

static imports

And each block is alphabetic sorted. But the testcases never enforced it, so we have some really strange formatting there.