-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSOC-52] Migration of rexov model #5
Conversation
…nd added buoyancy plugin to dave_ocean_waves.world
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial position
- for empty.world
- Rexrov starts half-way into the ground plane. setting initial z to
2.0
will spawn the rexrov in air and will drop due to the gravity
- Rexrov starts half-way into the ground plane. setting initial z to
- for ocean_waves
- Could we initiate at
z=-5
to be able to see it from the beginning.
- Could we initiate at
tag warning in joints
-
Multiple warning of unrecognized tag in the joints.
Warning [Utils.cc:132] [/sdf/model[@name="rexrov"]/joint[@name="thruster6_joint"]/limits:<data-string>:L465]: XML Element[limits], child of element[joint], not defined in SDF. Copying[limits] as children of [joint].
-
It seems, it should be
<limit>
instead of<limits>
and should be included within<axis>
tag
Imu sensor plugin not included model.sdf
Warning [Utils.cc:132] [/sdf/model[@name="rexrov"]/sensor[@name="imu_sensor"]:<data-string>:L595]: XML Element[sensor], child of element[model], not defined in SDF. Copying[sensor] as children of [model].
to Fix, add below to model.sdf
<plugin
filename="gz-sim-imu-system"
name="gz::sim::systems::Imu">
</plugin>
Added Mass
-
Just to avoid using 0 values, let's use this (from LRAUV)
<xDotU>-4.876161</xDotU> <yDotV>-126.324739</yDotV> <zDotW>-126.324739</zDotW> <kDotP>0</kDotP> <mDotQ>-33.46</mDotQ> <nDotR>-33.46</nDotR>
Rexrov in dave_ocean_waves flip upside down when surfaced.
-
As the center of gravity is too high to keep it straight, let's add values to bring it down
# in model.sdf <link name="base_link"> <inertial> <pose>0 0 -0.59 0 0 0</pose> # z value changed to -0.6
Collision model
- Collision model doesn't seem to match with visual? was it this way on original dave too? Could we adjust little to match with the visual?
- It especially looked strange since the collision model at the bottom is extended further out of the vehicle so that the rexrov would not touch ground.
![image](https://private-user-images.githubusercontent.com/7955120/344015195-1f83a522-d3bf-4a0a-88e3-bf16fe69c8f9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMDE0MjEsIm5iZiI6MTczOTMwMTEyMSwicGF0aCI6Ii83OTU1MTIwLzM0NDAxNTE5NS0xZjgzYTUyMi1kM2JmLTRhMGEtODhlMy1iZjE2ZmU2OWM4ZjkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMTkxMjAxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MGI2MDEyMzgyYTY1NzdjMjJkNWUwMDQwMjAwM2Y1N2E3ZmY2Y2E4NDQ0ZmFkMjdkMzhjY2NkOWM0YjRiNjdlMCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.9W_xCTM0XgyC8UTYs39BvyreKkoPW5c0Nh3nymhPLcs)
@woensug-choi Thank you for the review! I have addressed all the comments. Imu sensor plugin not included model.sdfThe issue was not actually with the plugin as it already existed. Rather, I had to move the following snippet inside the link for <sensor name="imu_sensor" type="imu">
<always_on>true</always_on>
<update_rate>1000.0</update_rate>
<topic>imu</topic>
</sensor> Collision modelYes, it was also defined this way on the original dave repo. However, after fixing the tag warnings, the collision model looks much better! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! It all look good to me! Go ahead and merge!
This PR introduces the migration of
rexrov
model. The following changes have been made:uuv_simulator
plugins.buoyancy
,thruster
, andhydrodynamic
plugins.dave_ocean_waves.world
Note: The added mass values for the model do not seem correct and cause the simulation to crash. Therefore, we have used values of LRAUV in their place for the hydrodynamics plugin.