Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSOC-52] Migration of rexov model #5

Merged
merged 15 commits into from
Jun 28, 2024
Merged

[GSOC-52] Migration of rexov model #5

merged 15 commits into from
Jun 28, 2024

Conversation

rakeshv24
Copy link
Collaborator

@rakeshv24 rakeshv24 commented Jun 27, 2024

This PR introduces the migration of rexrov model. The following changes have been made:

  1. Removed all uuv_simulator plugins.
  2. Converted xacro and urdf model files to sdf.
  3. Added buoyancy, thruster, and hydrodynamic plugins.
  4. Tested in dave_ocean_waves.world

Note: The added mass values for the model do not seem correct and cause the simulation to crash. Therefore, we have used values of LRAUV in their place for the hydrodynamics plugin.

@rakeshv24 rakeshv24 requested a review from woensug-choi June 27, 2024 20:31
Copy link

@woensug-choi woensug-choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial position

  • for empty.world
    • Rexrov starts half-way into the ground plane. setting initial z to 2.0 will spawn the rexrov in air and will drop due to the gravity
  • for ocean_waves
    • Could we initiate at z=-5 to be able to see it from the beginning.

tag warning in joints

Imu sensor plugin not included model.sdf

Warning [Utils.cc:132] [/sdf/model[@name="rexrov"]/sensor[@name="imu_sensor"]:<data-string>:L595]: XML Element[sensor], child of element[model], not defined in SDF. Copying[sensor] as children of [model].

to Fix, add below to model.sdf

 <plugin
   filename="gz-sim-imu-system"
   name="gz::sim::systems::Imu">
 </plugin>

Added Mass

  • Just to avoid using 0 values, let's use this (from LRAUV)

     <xDotU>-4.876161</xDotU>
     <yDotV>-126.324739</yDotV>
     <zDotW>-126.324739</zDotW>
     <kDotP>0</kDotP>
     <mDotQ>-33.46</mDotQ>
     <nDotR>-33.46</nDotR>

Rexrov in dave_ocean_waves flip upside down when surfaced.

  • As the center of gravity is too high to keep it straight, let's add values to bring it down

    # in model.sdf
     <link name="base_link">
        <inertial>
          <pose>0 0 -0.59 0 0 0</pose> # z value changed to -0.6

Collision model

  • Collision model doesn't seem to match with visual? was it this way on original dave too? Could we adjust little to match with the visual?
    • It especially looked strange since the collision model at the bottom is extended further out of the vehicle so that the rexrov would not touch ground.
image

@rakeshv24
Copy link
Collaborator Author

@woensug-choi Thank you for the review! I have addressed all the comments.

Imu sensor plugin not included model.sdf

The issue was not actually with the plugin as it already existed. Rather, I had to move the following snippet inside the link for base_link:

<sensor name="imu_sensor" type="imu">
  <always_on>true</always_on>
  <update_rate>1000.0</update_rate>
  <topic>imu</topic>
</sensor>

Collision model

Yes, it was also defined this way on the original dave repo. However, after fixing the tag warnings, the collision model looks much better!

Screenshot from 2024-06-28 01-07-37

@rakeshv24 rakeshv24 requested a review from woensug-choi June 28, 2024 08:08
Copy link

@woensug-choi woensug-choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It all look good to me! Go ahead and merge!

@rakeshv24 rakeshv24 merged commit a5bf461 into ros2 Jun 28, 2024
1 check passed
@rakeshv24 rakeshv24 deleted the robot-models branch June 28, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants