Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

98 correcting es lint errors on frontend #99

Merged
merged 5 commits into from
Jun 21, 2024
Merged

98 correcting es lint errors on frontend #99

merged 5 commits into from
Jun 21, 2024

Conversation

IPHUN1989
Copy link
Owner

Fix the following:

  • Add props validations to BoardGameForm and Register
  • Replace old fetch methods to useCallbacks in UserFavoritesSite and in GameDetails
  • Minor typos

Close #98

IPHUN1989 added 5 commits June 21, 2024 14:51
🐞 fix(BoardGameForm): Add props validation
b0ec888 
Add props validation to onSave and onCancel
🐞 fix(Login): Remove unused func
67aa435 
Remove unused onCancel (temporary fix)
🐞 fix(Register): Add prop validation
9172aec 
Add prop validation to onSave and onCancel
🐞 fix(GameDetails): Add useCallback
546fa0f 
Add useCallback to replace old method for fetchRatingForGame
🐞 fix(UserFavoritesSite): Add useCallback
4cca5a2 
Add useCallback for favBoardGamesFetch in order to replace old method
@IPHUN1989 IPHUN1989 added the bug Something isn't working label Jun 21, 2024
@IPHUN1989 IPHUN1989 added this to the SPRINT-5 milestone Jun 21, 2024
@IPHUN1989 IPHUN1989 requested a review from szplkflrn June 21, 2024 13:09
@IPHUN1989 IPHUN1989 self-assigned this Jun 21, 2024
@IPHUN1989 IPHUN1989 linked an issue Jun 21, 2024 that may be closed by this pull request
Correcting ES lint errors on frontend #98
Closed
@IPHUN1989 IPHUN1989 merged commit 9ad38a7 into development Jun 21, 2024
1 check passed
@IPHUN1989 IPHUN1989 deleted the 98-correcting-es-lint-errors-on-frontend branch June 21, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szplkflrn szplkflrn Awaiting requested review from szplkflrn

Assignees

@IPHUN1989 IPHUN1989

Labels
bug Something isn't working
Projects
ByteBattlers
Status: Done
Milestone
SPRINT-5
Development

Successfully merging this pull request may close these issues.

Correcting ES lint errors on frontend
1 participant
@IPHUN1989