Add accordion element of the design system #79
Conversation
| import type { Meta, StoryObj } from '@storybook/react' | ||
| import { Accordion } from '../../../sections/ui/accordion/Accordion' | ||
|
|
||
| const meta: Meta<typeof Accordion> = { |
There was a problem hiding this comment.
Please add a little jsdoc like a073464
That way we get the nice docs from Storybook for free. 😄
There was a problem hiding this comment.
@ekraffmiller can you take a look at this? I think is the only thing left in the review
There was a problem hiding this comment.
yes, I added that in my latest commit
|
Hi @MellyGray I added the tests you suggested - I had to add the ThemeProvider to the rendered component, we can remove that when we merge with the code that has cy.customMount(). Also I realized the alwaysOpen behavior wasn't working exactly as expected - in order to fix it, I had to set the defaultActiveKey with an array object, rather than a string. It's a little strange, but that's exactly how the underlying bootstrap component works. Let me know what you think. |
Look goods to me. I saw you added the defaultActiveKey array explanation in the jsdoc so it should be easy to use the component as described there. |
|
@ekraffmiller There merge conflicts, can you please resolve? Thanks! |
|
@kcondon merged with develop |
…ign-system Add accordion element of the design system
What this PR does / why we need it:
Adds an Accordion UI element
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
npm run storybook
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
no
Additional documentation: