-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics icon #2502
Comments
|
…averse, dataset, file pages in order to hide "Coming soon..." text. [ref #2502]
Disabled hover-toggle functionality from the Metrics block on the dataverse, dataset, file pages in order to hide "Coming soon..." text. Committed changes to a new branch titled "2016-01-ux-branch". This is branch is not associated with a milestone, which is why none is selected for this ticket. |
I just merged this into the 4.3 branch per my comment at #2852 (comment) |
The "develop" branch was created from 4.3 so this fix is already in develop. |
Yep. Already in develop. |
OK but not working. @mheppler |
I tested this again in dvn-build, as well as my local dev environment of the "develop" branch. Both environments show that the "hover-toggle" functionality of the Metrics widget has been disabled, so that when you mouse over the blue, burnt-orange and orange blocks at the bottom of the widget, the larger color-block above them remains on the green "Downloads" section. If this "hover-toggle" functionality is still being seen in an environment running the "develop" branch, it is most likely because the browser you are using has a cached version of the JS file that I edited in my commit 7a3a630. To clear this cached file from the browser, hold the "shift" key while you click the "refresh" button on your browser window. This will pull a new version of all cached files from the server. You should then see the new functionality. If not, pass this back to me with more details about the server, the browser and other details that I might need to replicate. |
OK, I had done shift+refresh but maybe I clicked on the tab which causes coming soon to appear. I understand this ticket is about hover only not removing click through. Closing. |
My apologies. Didn't realize that there was a "click" action that needed to be disbled as well. I am reopening this ticket to fix. |
…rse, dataset and file pages. [ref #2502]
Disable click-toggle functionality of the Metrics block on the dataverse, dataset and file pages. This code commit was made to the "feb-16-ux-fixes" branch and can be tested there. Sorry for the mixup regarding the hover vs. click functionalities. Should have caught that on the first pass. |
OK, hover and clicks are disabled. Closing. |
The "Metrics" icon has a prominent place at the top of the page but 3 of the 4 metrics (all but "Downloads", which does look great) say "Coming soon..." For now, should we simply remove "Coming soon..." (added in #1952) or consider removing the "Metrics" icon (and moving the "Downloads" number)?
The text was updated successfully, but these errors were encountered: