Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics icon #2502

Closed
pdurbin opened this issue Sep 10, 2015 · 12 comments
Closed

Metrics icon #2502

pdurbin opened this issue Sep 10, 2015 · 12 comments
Assignees
Labels
UX & UI: Design This issue needs input on the design of the UI and from the product owner
Milestone

Comments

@pdurbin
Copy link
Member

pdurbin commented Sep 10, 2015

The "Metrics" icon has a prominent place at the top of the page but 3 of the 4 metrics (all but "Downloads", which does look great) say "Coming soon..." For now, should we simply remove "Coming soon..." (added in #1952) or consider removing the "Metrics" icon (and moving the "Downloads" number)?

views

downloads

citations

shares

@mheppler
Copy link
Contributor

mheppler commented Nov 3, 2015

  • Disable the hover/toggle functionality, hiding the "Coming soon..." sections until they're ready to be developed.

@mheppler mheppler added UX & UI: Design This issue needs input on the design of the UI and from the product owner Status: Dev and removed Type: Suggestion an idea labels Nov 3, 2015
@mheppler mheppler self-assigned this Nov 3, 2015
@mheppler mheppler added this to the 4.3 milestone Nov 3, 2015
@mercecrosas mercecrosas modified the milestones: 4.3, In Review Nov 30, 2015
mheppler added a commit that referenced this issue Jan 6, 2016
…averse, dataset, file pages in order to hide "Coming soon..." text. [ref #2502]
@mheppler
Copy link
Contributor

mheppler commented Jan 6, 2016

Disabled hover-toggle functionality from the Metrics block on the dataverse, dataset, file pages in order to hide "Coming soon..." text.

Committed changes to a new branch titled "2016-01-ux-branch". This is branch is not associated with a milestone, which is why none is selected for this ticket.

@mheppler mheppler modified the milestones: 4.3, Not Assigned to a Release Jan 6, 2016
@mheppler mheppler assigned kcondon and unassigned mheppler Jan 6, 2016
@pdurbin
Copy link
Member Author

pdurbin commented Jan 11, 2016

I just merged this into the 4.3 branch per my comment at #2852 (comment)

@pdurbin
Copy link
Member Author

pdurbin commented Jan 26, 2016

The "develop" branch was created from 4.3 so this fix is already in develop.

@kcondon
Copy link
Contributor

kcondon commented Feb 3, 2016

@mheppler @pdurbin This is still happening on dvn-build, built from develop. Phil, this is now in develop branch, right?

@pdurbin
Copy link
Member Author

pdurbin commented Feb 3, 2016

Yep. Already in develop.

@kcondon
Copy link
Contributor

kcondon commented Feb 3, 2016

OK but not working. @mheppler

@kcondon kcondon assigned mheppler and unassigned kcondon Feb 3, 2016
@scolapasta scolapasta modified the milestones: 4.3, 4.2.4 Feb 4, 2016
@scolapasta scolapasta modified the milestones: 4.2.4, 4.3 Feb 4, 2016
@mheppler
Copy link
Contributor

mheppler commented Feb 4, 2016

I tested this again in dvn-build, as well as my local dev environment of the "develop" branch. Both environments show that the "hover-toggle" functionality of the Metrics widget has been disabled, so that when you mouse over the blue, burnt-orange and orange blocks at the bottom of the widget, the larger color-block above them remains on the green "Downloads" section.

If this "hover-toggle" functionality is still being seen in an environment running the "develop" branch, it is most likely because the browser you are using has a cached version of the JS file that I edited in my commit 7a3a630.

To clear this cached file from the browser, hold the "shift" key while you click the "refresh" button on your browser window. This will pull a new version of all cached files from the server. You should then see the new functionality. If not, pass this back to me with more details about the server, the browser and other details that I might need to replicate.

@mheppler mheppler assigned kcondon and unassigned mheppler Feb 4, 2016
@kcondon
Copy link
Contributor

kcondon commented Feb 4, 2016

OK, I had done shift+refresh but maybe I clicked on the tab which causes coming soon to appear. I understand this ticket is about hover only not removing click through. Closing.

@kcondon kcondon closed this as completed Feb 4, 2016
@mheppler
Copy link
Contributor

mheppler commented Feb 4, 2016

My apologies. Didn't realize that there was a "click" action that needed to be disbled as well. I am reopening this ticket to fix.

@mheppler mheppler reopened this Feb 4, 2016
@mheppler mheppler assigned mheppler and unassigned kcondon Feb 4, 2016
mheppler added a commit that referenced this issue Feb 4, 2016
@mheppler
Copy link
Contributor

mheppler commented Feb 4, 2016

Disable click-toggle functionality of the Metrics block on the dataverse, dataset and file pages.

This code commit was made to the "feb-16-ux-fixes" branch and can be tested there. Sorry for the mixup regarding the hover vs. click functionalities. Should have caught that on the first pass.

@mheppler mheppler assigned kcondon and unassigned mheppler Feb 4, 2016
@kcondon
Copy link
Contributor

kcondon commented Feb 8, 2016

OK, hover and clicks are disabled. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

5 participants