Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guestbook: Custom question dropdown displays behind popup #2918

Closed
mheppler opened this issue Feb 4, 2016 · 3 comments
Closed

Guestbook: Custom question dropdown displays behind popup #2918

mheppler opened this issue Feb 4, 2016 · 3 comments
Assignees
Labels
Feature: File Upload & Handling Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Milestone

Comments

@mheppler
Copy link
Contributor

mheppler commented Feb 4, 2016

The dropdown menu for selecting a multiple-choice answer for custom questions in the Guestbook popup form, displays behind the popup, so that you can not view the options.

@mheppler mheppler added UX & UI: Design This issue needs input on the design of the UI and from the product owner Status: Dev Feature: File Upload & Handling Type: Bug a defect labels Feb 4, 2016
@mheppler mheppler self-assigned this Feb 4, 2016
@mheppler mheppler added this to the 4.2.4 milestone Feb 4, 2016
@mheppler
Copy link
Contributor Author

mheppler commented Feb 4, 2016

This issue has been seen in the app before, and since I'm fixing it yet again, I've decided to be more prudent in my attempts to fix. I have gone identified all popups that have a component with a dropdown menu of some sort, so that I may test each to determine if this bug exists anywhere else.

  • roles-assign.xhtml, userGroupDialog, p:autoComplete
  • permissions-manage-files.xhtml, assignDialog, p:autoComplete
  • manage-groups.xhtml, viewGroup, p:autoComplete
  • explicitGroup-new-dialog.xhtml, explicitGroupNewDialog, p:autoComplete
  • editFilesFragment.xhtml, editFileTagsPopup, p:selectCheckboxMenu (x2)
  • editFilesFragment.xhtml, fileAdvancedOptions, p:tieredMenu
  • dataverse.xhtml, linkDataverseForm, h:selectOneMenu
  • dataset.xhtml, linkDatasetForm, h:selectOneMenu
  • dataset.xhtml, downloadPopup (Guestbook), p:selectOneMenu
  • dataset.xhtml, fileTagsPopup, p:selectCheckboxMenu (x2)
  • dataset.xhtml, deaccessionBlock, h:selectOneMenu

mheppler added a commit that referenced this issue Feb 5, 2016
…n the File Download > Guestbook workflow. [ref #2918]
@mheppler
Copy link
Contributor Author

mheppler commented Feb 5, 2016

Fixed dropdown menu for custom question that displayed behind popup in the File Download > Guestbook workflow.

After applying the new fix, I was not able to find the bug in any of the menus above. This solution should cover the use of any more PrimeFaces components that use a dropdown menu. (For the record, I do not believe this is an issue for generic JSF components.)

This code commit was made to the "feb-16-ux-fixes" branch and can be tested there.

@mheppler mheppler assigned kcondon and unassigned mheppler Feb 5, 2016
@kcondon
Copy link
Contributor

kcondon commented Feb 8, 2016

Popup in question is fixed, checked others mentioned and they are also working. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: File Upload & Handling Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

2 participants