Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions: update "roles" description for "Admins" to specify this role allows you to approve requests to restricted data #3189

Closed
sbarbosadataverse opened this issue Jun 29, 2016 · 2 comments · Fixed by #8666
Assignees
Labels
Feature: Permissions Type: Suggestion an idea User Role: Curator Curates and reviews datasets, manages permissions UX & UI: Design This issue needs input on the design of the UI and from the product owner
Milestone

Comments

@sbarbosadataverse
Copy link

I noticed that none of the roles, including "Admin" specifically says who can "approve" access to restricted data. I think this should be included somewhere in the "roles" description.
If this is a quick update, can we do it sooner rather than later?

@pdurbin pdurbin added Hackathon: Low Hanging Fruit UX & UI: Design This issue needs input on the design of the UI and from the product owner and removed Priority: High labels Jun 5, 2017
@pdurbin pdurbin added the User Role: Curator Curates and reviews datasets, manages permissions label Jul 4, 2017
@pdurbin
Copy link
Member

pdurbin commented Apr 19, 2018

For anyone wanting to work on this issue, I think the file to change is

scripts/api/data/role-admin.json

However, it might be one of the other "role-*" files in that directory.

@pdurbin pdurbin added the hacktoberfest It's Hacktoberfest! https://groups.google.com/g/dataverse-community/c/n_Nn_T2yA-w/m/BcoXO4tEAQAJ label Sep 21, 2020
@pdurbin
Copy link
Member

pdurbin commented Apr 27, 2022

These days this string is here (now that roles are internationalized):

src/main/java/propertyFiles/BuiltInRoles.properties

I would suggest a change like this:

$ git diff src/main/java/propertyFiles/BuiltInRoles.properties
diff --git a/src/main/java/propertyFiles/BuiltInRoles.properties b/src/main/java/propertyFiles/BuiltInRoles.properties
index 3c4b802000..2687843ee9 100644
--- a/src/main/java/propertyFiles/BuiltInRoles.properties
+++ b/src/main/java/propertyFiles/BuiltInRoles.properties
@@ -1,5 +1,5 @@
 role.admin.name=Admin
-role.admin.description=A person who has all permissions for dataverses, datasets, and files.
+role.admin.description=A person who has all permissions for dataverses, datasets, and files, including approving requests for restricted data.
 role.editor.name=Contributor

konradperlowski added a commit to konradperlowski/dataverse that referenced this issue Apr 29, 2022
kcondon added a commit that referenced this issue Apr 29, 2022
@pdurbin pdurbin added this to the 5.11 milestone May 4, 2022
@pdurbin pdurbin removed Hackathon: Low Hanging Fruit Help Wanted: Code Mentor: pdurbin hacktoberfest It's Hacktoberfest! https://groups.google.com/g/dataverse-community/c/n_Nn_T2yA-w/m/BcoXO4tEAQAJ labels Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Permissions Type: Suggestion an idea User Role: Curator Curates and reviews datasets, manages permissions UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants