Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking Dataverses does not show proper number of Datasets in facet results #6262

Closed
sbarbosadataverse opened this issue Oct 8, 2019 · 10 comments · Fixed by #6564
Closed
Assignees

Comments

@sbarbosadataverse
Copy link

When you link an entire dataverse to another dataverse, it does not display the number of datasets in the linked dataverse, on the target dataverse page:
see https://dataverse.harvard.edu/dataverse/HarvardUniversity
Where I have linked several dataverses with multiple collections and the only dataset facet that shows (1) is for the single dataset I linked.

Merce wants it to display #datasets contained within the linked dataverses.

@sbarbosadataverse sbarbosadataverse added the Type: Feature a feature request label Oct 8, 2019
@mheppler
Copy link
Contributor

mheppler commented Oct 8, 2019

Looking at the Internet Connectivity Statistics dataverse, which was linked to Harvard University Dataverse, it appears that in addition to missing the 2 child datasets, it is missing 5 child dataverses (however 4 of those are empty, only Country Profiles dataverse has any datasets).

@mheppler
Copy link
Contributor

mheppler commented Oct 8, 2019

Related to #4936.

@TaniaSchlatter
Copy link
Member

Screen shot to indicate where this shows in the UI:

linked_counts_incomplete

@sbarbosadataverse
Copy link
Author

The screen shot showing 1 dataset facet

Screen Shot 2019-10-08 at 2 06 27 PM

@djbrooke
Copy link
Contributor

djbrooke commented Oct 9, 2019

@sbarbosadataverse I'm assuming this is happening because we want to avoid double (or triple, etc.) counting as we roll up to higher levels. I can see why it's confusing here but I can't think of an easy solution for this. I'll think about this, but suggestions welcome.

@djbrooke djbrooke changed the title linking dataverses should display the number of datasets in the target dataverse linked to Show proper # of dataverses and datasets in facet view when those dataverses and datasets have been linked to a dataverse Oct 9, 2019
@sbarbosadataverse
Copy link
Author

@djbrooke Not sure what the reasoning was, but Merce would like the numbers to display datasets linked. Thanks

@djbrooke
Copy link
Contributor

djbrooke commented Oct 9, 2019

@sbarbosadataverse Got it, I understand the request in this context, but we don't want to trade one problem for another. I'll work with Merce to learn more and implement a solution here.

@scolapasta
Copy link
Contributor

This seems to me like it would be an indexing issue (though I did try reindeixing one of the datasets in question and that didn't "add it"). I thought this used to work, i.e. link a dataset all it's children would be linked, as well.

(double counting shouldn't be a risk, as the datasets in question would still be one "document" in Solr)

@scolapasta
Copy link
Contributor

To add more, I think the logic in the indexing would have to check if a parent was linked (and up the tree to see if any parent were linked), so it's a little more complicated than just a simple indexing issue.

I'm still a little surprised that we didn't do this originally (though there are definitely performance considerations with these recursive looks).

@djbrooke djbrooke removed the Type: Feature a feature request label Dec 9, 2019
@djbrooke djbrooke self-assigned this Jan 15, 2020
@djbrooke djbrooke changed the title Show proper # of dataverses and datasets in facet view when those dataverses and datasets have been linked to a dataverse Linking Dataverses does not show proper number of Datasets in facet results Jan 15, 2020
@djbrooke
Copy link
Contributor

djbrooke commented Jan 15, 2020

  • This may be a design shortcut made back in the move to 4.0, we should revisit
  • Child Datasets of linked dataverses should be discoverable using search within the host dataverse
  • We should avoid double counting, not that there is one card per object no matter how many time it's been linked

@djbrooke djbrooke removed their assignment Jan 15, 2020
@sekmiller sekmiller self-assigned this Jan 17, 2020
sekmiller added a commit that referenced this issue Jan 23, 2020
sekmiller added a commit that referenced this issue Jan 23, 2020
sekmiller added a commit that referenced this issue Jan 23, 2020
sekmiller added a commit that referenced this issue Jan 28, 2020
sekmiller added a commit that referenced this issue Jan 29, 2020
sekmiller added a commit that referenced this issue Jan 29, 2020
sekmiller added a commit that referenced this issue Jan 29, 2020
sekmiller added a commit that referenced this issue Jan 29, 2020
sekmiller added a commit that referenced this issue Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants