Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Dataset - Failed publish error msg displayed on latest published version, not on draft version #6947

Closed
mheppler opened this issue May 29, 2020 · 2 comments · Fixed by #7118

Comments

@mheppler
Copy link
Contributor

mheppler commented May 29, 2020

While chasing publish lock UI bugs on demo (4.20), I stumbled upon this confusing behavior.

PROBLEM

After the publish lock warning msg clears upon refresh, and something failed, the error msg is displayed on the latest published version (see screenshot below), and not on the draft version where the publish workflow was started by the user when they clicked the Publish btn.

This leads to confusion. The msg text even suggests, "please try again", but there is no Publish btn displayed to click!

SUGGESTION

The publish error msg should be displayed on the draft version, not the latest published version.

REFERENCES

Screen Shot 2020-05-29 at 11 17 02 AM

@djbrooke
Copy link
Contributor

Thanks @mheppler. I think we fixed something similar this recently, but a quick search didn't turn anything up. :/ I agree with your suggestion about how to handle this. I'll add to up next.

@landreev
Copy link
Contributor

Confirming that the PR #7118 will also fix this issue. If anything goes wrong during an attempt to publish, the user will end up staying on the draft page. And not, confusingly, on the last previously published version (if exists).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants