Publish Dataset - Publish lock warning msg alert displayed on latest published version, not on draft version

[mheppler]

(Not sure how related this is to recently opened Publish Dataset - Failed publish error msg displayed on latest published version, not on draft version #6947)

PROBLEM

When you create a draft from a published dataset, and then publish those changes, the publish lock warning msg alert (see screenshot below) displays on the latest published version and not on the draft dataset.

USE CASE WORKFLOW

Thank you, to @kcondon for the outline provided in his comment on PR #6909. Moved this to a new issue, because the bug existed in 4.20, as Kevin determined as he wrote, "was able to reproduce on demo but needed async mode enabled."

Please be aware that async mode needs to be invoked, ideally by setting curl -X PUT -d -1 http://localhost:8080/api/admin/settings/:PIDAsynchRegFileCount and using the test Datacite credentials

Steps to reproduce:

1. create a dataset with no file but with the following description: THIS IS DATASET VERSION 1! YOU SHOULD NOT SEE THIS WHEN PUBLISHING DATASET VERSION 2!
2. publish
3. edit metadata, change description to read This is dataset version 2.
4. publish
5. with async mode enabled, see above, the publish lock always appears while publishing.
6. while publishing is taking place (lock is present), you will see dataset version now shows 1.0 and the description shows the one from v1.0. once published, goes to 2.0.

SUGGESTION

The publish lock warning msg alert should display on the dataset draft, where the user clicked the Publish btn, and not on the latest published version. This is confusing. You might be looking at information on your dataset that you thought you changed.

RESOURCES

[mheppler]

Also, there is no publish success msg alert displayed when the page refreshes, the publish lock is gone and the view changes to the new published version.

[mheppler]

Closing this issue. Was not able to replicate on my localhost or demo (5.3 both). I am opening a new issue related to the publish success msg that's gone missing though.