Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add value "cell counting" to Life Science metadatablock's Measurement Type field vocabulary #8655

Closed
jggautier opened this issue Apr 26, 2022 · 1 comment · Fixed by #9735
Milestone

Comments

@jggautier
Copy link
Contributor

jggautier commented Apr 26, 2022

What steps does it take to reproduce the issue?

  • When does this issue occur?
    When adding and editing dataset metadata fields in the Life Sciences metadatablock

  • Which page(s) does it occurs on?
    Edit dataset page

  • What happens?
    When choosing controlled vocabulary values from the Measurement Type field (studyAssayMeasurementType), the "cell counting" value is missing.

  • To whom does it occur (all users, curators, superusers)?
    Curators and depositors

  • What did you expect to happen?
    "cell counting" should be an option in the dropdown

Which version of Dataverse are you using?
v5.10.1

Any related open or closed issues to this bug report?
#7278, where I think the value was accidentally removed during an unrelated change to the metadatablock

Screenshots:

"cell counting" is not an option of the Measurement Type field when adding or editing metadata on Demo Dataverse (v5.10.1)
Screen Shot 2022-04-26 at 2 09 56 PM

"cell counting" is an option of the Measurement Type field when adding or editing metadata on Harvard Dataverse Repository (v5.10.1)
Screen Shot 2022-04-26 at 2 12 06 PM

@jggautier jggautier changed the title Re-add value "cell counting" to Life Science metadatablock's studyAssayMeasurementType vocabulary Re-add value "cell counting" to Life Science metadatablock's Measurement Type field vocabulary Apr 26, 2022
@pdurbin
Copy link
Member

pdurbin commented Apr 26, 2022

Thanks, @jggautier. This becomes a problem for people reading the API Guide and trying to use the dataset-create-new-all-default-fields.json file to create a dataset: https://guides.dataverse.org/en/5.10.1/api/native-api.html#create-a-dataset-in-a-dataverse-collection

The dataset is not created and they see this error instead:

{"status":"ERROR","message":"Error parsing Json: Value 'cell counting' does not exist in type 'studyAssayMeasurementType'"}

It looks like "cell counting" was removed in ac71026, so Dataverse 5.1, as part of this pull request (as you said):

I assume we should simply add "cell counting" back in.

It probably wouldn't be a bad idea to also add a test to exercise dataset-create-new-all-default-fields.json as well because it probably would have helped us catch this bug a lot sooner.

As you point out, installations older that 5.1 still have "cell counting". This is because the "reload metadata block" logic can add values but can't remove them.

luddaniel added a commit to Recherche-Data-Gouv/dataverse that referenced this issue Jul 26, 2023
sekmiller added a commit that referenced this issue May 8, 2024
…unting-biomedical-tsv

#8655 Re-add value 'cell counting' to Life Science metadatablock's Measurement Type field vocabulary
@pdurbin pdurbin added this to the 6.3 milestone May 8, 2024
@DS-INRAE DS-INRAE moved this to Done in Recherche Data Gouv Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2 participants