Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZID getProviderInformation fails if doi.baseurlstring is not set #9486

Closed
qqmyers opened this issue Mar 29, 2023 · 0 comments · Fixed by #9487
Closed

EZID getProviderInformation fails if doi.baseurlstring is not set #9486

qqmyers opened this issue Mar 29, 2023 · 0 comments · Fixed by #9487
Milestone

Comments

@qqmyers
Copy link
Member

qqmyers commented Mar 29, 2023

What steps does it take to reproduce the issue?
Discovered by @poikilotherm when logging was added in #8674: if doi.baseurlstring is not set, the EZID getProviderinfo() method tries to add a null to a list. After #8674, this method is called (for some fine logging) in PidUtil.parseAsGlobalId when GlobalIDs are created from Strings, resulting in a failure in methods like Finalize publication.

  • When does this issue occur?
    when doi.baseurlstring is not set.

Which version of Dataverse are you using?
develop, post #8674

PR to follow

poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Mar 31, 2023
This relates to IQSS#9486, but with the switch of the properties
to come from MPCONFIG, this is much easier to do.

We do create the provider object in any case, because otherwise the
stateless EJB mechanism will be very unhappy. We do not login
if there is no password and username given, so avoid the exceptions.
We only log a warning if only one of both is given (which is clearly an
error).
@pdurbin pdurbin added this to the 5.14 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants