convert workflowCodeRepository field into a clickable link #10441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add href tag to display url in computational workflow metadata block
Added href tag to "displayFormat" field in computational workflow metadata block tsv file
pdurbin
changed the title
Added release notes for 10339 update
Clarified that link is now clickable. Co-authored-by: Philip Durbin <[email protected]>
pdurbin
changed the title
|
@kmika11 How'd you resolve those white space issues? Did you make the changes in a Google Sheet, save the sheet as a TSV and use that? |
|
I "copied raw file" from github https://github.com/IQSS/dataverse/blob/develop/scripts/api/data/metadatablocks/computational_workflow.tsv and pasted into a text editor and made the edit there before saving to a .tsv. But, I bet the google sheet strategy would work too. As long as you don't open it in a spreadsheet software (like excel) to make the edits |
scolapasta
approved these changes
Apr 1, 2024
18 tasks
|
As is, it looks like the PR both makes the URL into a link and adds quotes around it: @kmika11 - is this a question for you or someone else? |
|
I don't think we want the quotes. Good catch, @landreev |
Co-authored-by: Philip Durbin <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add href tag to display url in computational workflow metadata block
What this PR does / why we need it: Adds
hreftag to the computational workflow tsv file to properly display and link the url required in the External Code Repository URL field.Which issue(s) this PR closes:
Special notes for your reviewer: Redid #10439 on new branch and fixed white space changes.
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here: Makes link clickable on dataset page.
Is there a release notes update needed for this change?:
Additional documentation: