-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Banner IT improvements after resolving issues on rocky. #10565
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -79,6 +79,7 @@ | |||
import jakarta.ws.rs.core.Response.Status; | |||
|
|||
import org.apache.commons.io.IOUtils; | |||
import org.apache.commons.lang.exception.ExceptionUtils; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.imports.IllegalImportCheck> reported by reviewdog 🐶
Illegal import - org.apache.commons.lang.exception.ExceptionUtils.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
With the last changes I updated the endpoint |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a quick look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc change looks good. I left comments on the Makefile.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left another comment on the Makefile.
This comment has been minimized.
This comment has been minimized.
I had to change the make |
This comment has been minimized.
This comment has been minimized.
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
These changes were in 853965e as part of PR IQSS#10565 but were lost during resolution of a merge conflict.
What this PR does / why we need it:
After debugging this test and the endpoint to resolve the issues on #10312 I made a few changes:
api/admin/bannerMessage
has been extended so the ID is returned when created, this will allow to delete a specific banner with ID after creation. This is not a breaking change since is not removing anything from the JSON.Which issue(s) this PR closes:
Closes #10312
Is there a release notes update needed for this change?:
Yes.