Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Dataset fix #10566

Merged

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented May 16, 2024

What this PR does / why we need it: With two or more files in a draft dataset, the Delete Dataset option in the dataset page menu fails. (The user is directed to the collection page, but the draft dataset still exists.

Which issue(s) this PR closes:

Closes #

Special notes for your reviewer: There is a long discussion in the core team's slack. What changed to start causing this/why explicitly deleting the filemetadata list from the version is now a fix is not completely clear. (~makes sense why you'd need to get rid of the fm references in the version, but why wasn't that needed before?)

Suggestions on how to test this: Add a dataset with two or more files. Verify that delete works as expected. Could/should also test the api/datasets/id/destroy call (same command) and that harvesting still works (harvesting calls destroy dataset if a dataset with that DOI already exists).

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@qqmyers qqmyers added this to the 6.3 milestone May 16, 2024
@coveralls
Copy link

coveralls commented May 16, 2024

Coverage Status

coverage: 20.588% (-0.002%) from 20.59%
when pulling 91af39f on GlobalDataverseCommunityConsortium:deletedatasetfix
into da3dd95 on IQSS:develop.

Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
Somewhat unsettling, the fact that it's not clear at all why it wasn't failing before.
A dumb guess - could it be that the rate limit check added in the command engine has added just enough delay to the command execution to trigger this?
That would mean that the issue is present in stock 6.2 as well, but we just lucked out and didn't encounter it, due to somewhat intermittent nature of the bug.

@qqmyers qqmyers added the Status: Needs Input Applied to issues in need of input from someone currently unavailable label May 17, 2024
@qqmyers qqmyers self-assigned this May 17, 2024
@qqmyers qqmyers force-pushed the deletedatasetfix branch from bb39934 to 91af39f Compare May 17, 2024 17:33
@qqmyers qqmyers removed the Status: Needs Input Applied to issues in need of input from someone currently unavailable label May 17, 2024
@qqmyers qqmyers removed their assignment May 17, 2024
@sekmiller sekmiller self-assigned this May 21, 2024
@sekmiller sekmiller merged commit e3bfe6c into IQSS:develop May 22, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants