#10466: quick fix for math challenge contact form on 403 error page #10602
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If a user wishes to access a page, but is prevented from doing so by a rights issue (ACL), the error message on page 403 indicates this. Actually, the form can no longer be submitted because the mathematical challenge is empty. This PR corrects this and makes it possible to submit this form again.
Which issue(s) this PR closes:
Closes #10466
Special notes for your reviewer:
I do a simple quick fix, I don't understand why the
SendFeedbackDialog.initUserInput
method isn't called. But with the new SPA interface, this bug will disappear, as it's linked to the current JSF view (view from MVC). So it seems to me that this is acceptable.Suggestions on how to test this:
I use this test case to validate this PR :
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No change
Is there a release notes update needed for this change?:
I don't think because the contact form on forbidden access page is a small functionality. But if needed I can write them.
Additional documentation:
No