Delete Files From Dataset #11230
Open
Delete Files From Dataset #11230
+227
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asadmin set configs.config.default-config.network-config.protocols.protocol.http-listener-1.http.allow-payload-for-undefined-http-methods=true
qqmyers
added
Size: 3
stevenwinship
requested changes
Feb 11, 2025
| if ((pid == null) && (dvObject instanceof DataFile df)) { | ||
| pid = df.getOwner().getGlobalId(); | ||
| } | ||
| pidProvider = PidUtil.getPidProvider(pid.getProviderId()); | ||
| XMLStreamWriter xmlw = XMLOutputFactory.newInstance().createXMLStreamWriter(outputStream); | ||
| xmlw.writeStartElement("resource"); | ||
| boolean deaccessioned=false; |
There was a problem hiding this comment.
This change is already in a PR that is in QA. Once it's merged please remove this and merge from develop
stevenwinship
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a deleteFiles method to the native API for datasets, using PUT as the HTTP verb to match the existing delete metadata calls.
Which issue(s) this PR closes:
Special notes for your reviewer:
Note for posterity: To be able to use DELETE with a payload, Payara has to have an option set:
The consensus in slack was to not use this approach, but if we decide to in the future, we'd need to include instructions to make this change in Payara.
Suggestions on how to test this:
There's an IT test that creates a dataset with files, try to delete some, publishes the dataset and then tries to delete others. It also tests using a bad fileId or datasetId or using a user w/o permissions. Those or other cases could be manually tested as well. The documentation (in the native api section) gives a curl example.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included.
Additional documentation: