DANS/CSL - Fix create dataset bug #11313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
The test run at https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11313/1/console failed with "Connection to ec2-44-202-163-64.compute-1.amazonaws.com closed by remote host" but this happens intermittently sometimes. I kicked off another run but as this PR only changes xhtml it shouldn't affect the API tests.
I didn't test this PR but the change seems reasonable. I'm sending this to QA.
|
Testing passed - merging PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Late changes to #11163 led to a failure when trying to create a new dataset in the JSF UI as reported in slack (see https://iqss.slack.com/archives/C04MJ76A34Z/p1741295920525239 ). In brief, code to get the JSON needed to generate different citation styles was moved to where it would run in the dataset page create mode. That failed because the new DatasetType is null at this point. A fix is to put the relevant code in a ui:fragment that is only rendered when editMode is not CREATE. That's what this PR does.
Which issue(s) this PR closes:
Special notes for your reviewer: Using https://github.com/IQSS/dataverse/pull/11313/files?w=1 you can see the only change is the open/close for the ui:fragment.
Suggestions on how to test this: The only change is in the dataset.xhtml, so verifying the you can create a dataset and the new citation styles still work for an existing dataset should do it.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: