2437 handle support iqss #3826
Merged
2437 handle support iqss #3826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w extends IdServiceBean, implemented as far as it used to be called
(cherry picked from commit c269368)
# Conflicts: # src/main/java/edu/harvard/iq/dataverse/engine/command/impl/DeaccessionDatasetVersionCommand.java
- pulled up methods to AbstractIdServiceBean - implemented methods of HandleNetServiceBean that still threw a NotImplementedException and were called somewhere This is a squashed commit of https://github.com/DANS-KNAW-jp/dataverse/pull/1 alias https://github.com/DANS-KNAW-jp/dataverse/tree/DDN-184-handle-implementation
DDN-184 doi interface
DANS style for pull request template
Changed explicit calling of Datacite related error to generic message with the name of registration service being used.
Error messages with the registration service for publishing dataset.
Adjustment on Deaccession and Destroy commands
5 tasks
The conflict was with dataset.delete.error vs. dataset.delete.error.datacite in Bundle.properties
Fixed the :ref: Sphinx warnings and expanded documentation of handles support.
Added clarifications on the use of DoiProvider and DoiSeparator.
Removed note about 20 before handle prefix. The entire namespace should be used without alteration.
Added clarification about which JVM Options and Database Settings apply to which kinds of installations.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist