Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4703 dcm s3 2 #4946

Merged
merged 17 commits into from
Aug 24, 2018
Merged

4703 dcm s3 2 #4946

merged 17 commits into from
Aug 24, 2018

Conversation

matthew-a-dunlap
Copy link
Contributor

@matthew-a-dunlap matthew-a-dunlap commented Aug 13, 2018

Related Issues

Pull Request Checklist

@coveralls
Copy link

coveralls commented Aug 13, 2018

Coverage Status

Coverage decreased (-0.03%) to 15.456% when pulling d359f73 on 4703-dcm-s3-2 into 438c6e6 on develop.

@matthew-a-dunlap
Copy link
Contributor Author

matthew-a-dunlap commented Aug 13, 2018

There is documentation related to this work that currently only exists in the Dataverse github issue. It is an open question whether that documentation should live in Dataverse or https://github.com/sbgrid/data-capture-module

@pameyer
Copy link
Contributor

pameyer commented Aug 13, 2018

@matthew-a-dunlap Things like ./asadmin create-jvm-options "-Ddataverse.files.dcm-s3-bucket-name=test-dcm" seem like they might belong in the Dataverse docs; things like pip install awscli seem to me like they'd belong in the DCM docs (which I think you've already added them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants