remove parentheses from dataset contact affiliation #6570 #6619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekmiller
requested changes
Feb 6, 2020
|
@sekmiller I just reduced code duplication in e3a25fa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR closes:
Closes #6570
Special notes for your reviewer:
I copied and pasted a similar method above. Here's where the similar method is now used (one fewer place in this pull request since the Search API uses the new method):
Suggestions on how to test this:
Add an affiliation to the contact of a dataset and inspect the JSON output from the Search API when finding that dataset. The value should not be wrapped in parentheses, like it is in 4.19.
Does this PR introduce a user interface change?:
No.
Is there a release notes update needed for this change?:
Yes, added. Technically this is a backward incompatible change but it's a small one and I don't think it's worth adding a configuration option for it. Sorry, API users. You no longer need to strip parentheses from affiliation if you were before.
Additional documentation:
None.