-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8210 importddi fix #8483
8210 importddi fix #8483
Conversation
Update from Iqss develop
Update develop from IQSS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks great.
I did suggest a doc change, so please take a look.
The test is failing but it's our fault. Please hold on until we resolve #8489.
@lubitchv @landreev @qqmyers @scolapasta we've been discussing in IQSS and community Slack but not all at once. Let me try to get us all on the same page. @landreev made pull request #8491 to address the collectionMode change that affects this pull request about DDI import. As he notes in the description, it's hard to test it since DDI import is broken. So, I went ahead and merged it into this pull request. The new testImportDDI test runs fine on my laptop. I'll wait until Jenkins is happy with it before moving this pull request to QA. Obviously, if anyone else wants to do further review of this pull request, please go ahead. Meanwhile, @qqmyers also has a change for As for this pull request, I think I'm done making changes. Thank you @lubitchv for committing my doc suggestion. That last thing I haven't mentioned is that I removed one of the test XML files since they're identical. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new "import DDI" test just passed on Jenkins. Moving to QA.
What this PR does / why we need it:
importddi is broken because ddi xml does not have corresponding subject field. The fix is by filling Subject field with "N/A" similar to Sword Api.
Which issue(s) this PR closes:
Suggestions on how to test this:
testImportDDI was added to DataversesIT.
One can also test by using curl:
curl -H X-Dataverse-key:$API_TOKEN -X POST $SERVER_URL/api/dataverses/$DATAVERSE_ID/datasets/:importddi --upload-file ddi_dataset.xml
Sample xml file is in doc/sphinx-guides/source/_static/api/ddi_dataset.xml
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
Release notes update is added to doc/release-notes/8210-importddi-fix.md
Additional documentation:
Documentation added to Native Api guide