#8617 Branding customization docs refactoring #8638
Conversation
| @@ -2613,3 +2687,6 @@ To override the default list with Docs, Data, Code, and Workflow: | |||
| To remove the override and go back to the default list: | |||
|
|
|||
| ``curl -X PUT -d '' http://localhost:8080/api/admin/settings/:FileCategories`` | |||
|
|
|||
| .. |dvPageBlocks| image:: ./img/dvBrandingCustBlocks.png | |||
There was a problem hiding this comment.
@j-n-c I'm working on a more complete review, but a quick question for you. How did you create this PNG file? What if we want to edit it in the future? Is it possible to get the source of the image? I'm thinking about an SVG file, for example. Something we can edit. Thanks.
There was a problem hiding this comment.
nitpick: This appears in the preview, but shouldn't the image be referenced at the place of use? Scrolling all the way down (2000 lines) seems cumbersome.
There was a problem hiding this comment.
@j-n-c thanks! The "dv.drawio" is only 30 KB so I'll probably just commit it to my branch (I'm planning on making a pull request for you to review).
I was able to import it into https://app.diagrams.net without any trouble. Here's a screenshot:
@poikilotherm I guess it's personal preference. If you look at the README you'll see a long list of links at the bottom that are used throughout. I see this as similar. Put all that junk at the bottom.
There was a problem hiding this comment.
nitpick: This appears in the preview, but shouldn't the image be referenced at the place of use? Scrolling all the way down (2000 lines) seems cumbersome.
@poikilotherm In ErykKul#1 I said "you were right". 😄
People just want to add database settings to the bottom of the config page, as they should. Don't make me think!
Hopefully this wording is considered an improvement! I also looked into the installation name and how it interacts with :InstallationName and :SystemEmail.
What this PR does / why we need it:
Refactor Branding customization docs:
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: