-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8669 add bind to doc ready #8670
Conversation
Upon further investigation I discovered that the onload script was running the rebind method, but that the rebind method was throwing errors and not running to completion. I put several try/catch blocks into the rebind method to see what the error messages were posting. Here is a sample: `TypeError: Error: cannot call methods on tooltip prior to initialization; attempted to call method 'hide' TypeError: TypeError: undefined is not a function (near '...$('#sharrre-widget').sharrre...')` When the rebind is called from document.ready none of these errors occur. |
This one may be the most on point: Error: cannot call methods on tooltip prior to initialization; attempted to call method 'hide' but any error essentially halts the method in its tracks. So perhaps something happens in between the onload script and document ready that completes the initialization? |
we took "defer" off the scripts that need to be present for the onloadScript to run. The featured dataverse carousel still works with the carousel.js script still deferred. |
What this PR does / why we need it: Fixes tool tips on Add Data (Dataverse or Dataset)
Which issue(s) this PR closes:
Closes #8669 Tool Tips not working on New Dataset and New Dataverse
Special notes for your reviewer: removed defer from the scripts required by the rebind (onload) method
Suggestions on how to test this: See that you get tool tips on New Dataset/ New Dataverse - also advanced search.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: