-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8778 harvester ddi exporter #8786
Conversation
Update from IQSS develop
Hmmm. This is a pretty big deal of a change. I feel like this should've been discussed some more. |
As for discussion in the ticket, oai_ddi format remains with short version. DDI format is made harvastable. The label for DDI format was replaced with DDI_full. |
@lubitchv hi! Yesterday I merged the latest from develop into this PR (I hope you don't mind!) and now this test is failing: java.lang.AssertionError: expected:<5> but was:<6> Can you please take a look? Also, @landreev recently added a bunch of tests in the following PR and you're welcome to add additional tests if you like! |
From looking at the code I'm still confused. It sure seems like the existing short format would disappear and replaced by the long format. 🤔 Needs discussion or at least some testing. |
If you are still interested in this PR, can you please merge and resolve any merge conflicts with the latest from develop? If so, we can prioritize reviewing and QAing the changes. If we don’t hear from you by May 22, 2024, we’ll go ahead and close this PR (it can always be reopened after that date, if there is still interest). |
Closing. |
What this PR does / why we need it:
It replaces short version of harvester exporter XML with a full version, i.e it adds dataDscr and fileDscr sections.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Use dataset with tab files. Run:
curl http:/localhost:8080/oai?metadataPrefix=ddi&verb=GetRecord&identifier=$PERSISTENT_ID
The resulting xml should have dataDscr and fileDscr sections.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No