Make Series multiple #9255

[philippconzett]

What this PR does / why we need it:
Allows depositors to define multiple instances of the metadata field Series in the Citation Metadata block.

Which issue(s) this PR closes:

Closes #9255

Special notes for your reviewer:
No.

Suggestions on how to test this:
Create a test dataset with multiple instances of the Series metadata field.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No. There are already other metadata fields that are repeatable and facetable.

Is there a release notes update needed for this change?:
Should briefly mention that the field now is repeatable.

Additional documentation:
No.

[mreekie]

Prio meeting with Stefano.

• Moved from Community Backlog to ordered backlog

[sekmiller]

Based on the work I did on making production place multiple (#9254) this PR will need additional release notes with respect to upgrading the citation block - also schema.xml and searching - possibly import

[sekmiller]

Updates for solr are done. Still needs work on ImportDDIServiceBean for multiple series. Also there may need to be notes on backwards incompatibility for dataset json that do not note that series can be multiple.

[sekmiller]

Also, currently getting an error on finalize publish export all formats.

[coveralls]

Coverage: 20.167% (-0.02%) from 20.184% when pulling ec69508 on philippconzett:patch-3 into 4903e9f on IQSS:develop.

[landreev]

Just grabbed this for review now. Based on a very quick first glance, the correct changes were made in the export DDI util (the part that we overlooked when productionPlace was made multiple), but I need to take a closer look.

[landreev]

@sekmiller I would like to take you up on syncing the branch with develop (first @philippconzett's fork needs to be synced with IQSS:dataverse). I don't think I can sync the actual remote fork, but I did try this on my own local checkout of Philipp's branch; and, to my surprise, it auto-merges just fine with IQSS/develop, without any conflicts in DdiExportUtil.java.
Once this is done, I'd like to change the control "all fields" json file and the corresponding control ddi export to actually include multiple series, to make sure we are testing the field correctly. Again, I tried this in my local checkout and the tests passed.
So, I'm talking about replacing

             {
              "seriesName": {
                "typeName": "seriesName",
                "multiple": false,
                "typeClass": "primitive",
                "value": "SeriesName"
              },
              "seriesInformation": {
                "typeName": "seriesInformation",
                "multiple": false,
                "typeClass": "primitive",
                "value": "SeriesInformation"
              }
            }

with

             {
                "seriesName": {
                  "typeName": "seriesName",
                  "multiple": false,
                  "typeClass": "primitive",
                  "value": "SeriesName1"
                },
                "seriesInformation": {
                  "typeName": "seriesInformation",
                  "multiple": false,
                  "typeClass": "primitive",
                  "value": "SeriesInformation1"
                }
              },
              {
                "seriesName": {
                  "typeName": "seriesName",
                  "multiple": false,
                  "typeClass": "primitive",
                  "value": "SeriesName2"
                },
                "seriesInformation": {
                  "typeName": "seriesInformation",
                  "multiple": false,
                  "typeClass": "primitive",
                  "value": "SeriesInformation2"
                }
              }

in src/test/java/edu/harvard/iq/dataverse/export/ddi/dataset-create-new-all-ddi-fields.json
and replacing

      <serStmt>
        <serName>SeriesName</serName>
        <serInfo>SeriesInformation</serInfo>
      </serStmt>

with

     <serStmt>
        <serName>SeriesName1</serName>
        <serInfo>SeriesInformation1</serInfo>
      </serStmt>
      <serStmt>
        <serName>SeriesName2</serName>
        <serInfo>SeriesInformation2</serInfo>
      </serStmt> 

in src/test/java/edu/harvard/iq/dataverse/export/ddi/exportfull.xml.

Aside from this, I'm happy with everything in this PR, providing all the Jenkins tests pass after this.
Thank you, and sorry for coming up with more work.

[pdurbin]

In 7748450 I merged develop into this branch/PR. I more or less followed: https://guides.dataverse.org/en/5.13/developers/version-control.html#adding-commits-to-a-pull-request-from-a-fork

The only wrinkle is if there are multiple branches called patch-3 (in this case) across remotes you have configured. I ended up deleting a remote to get down to just the single patch-3 I wanted to update.

[landreev]

Great, thank you @pdurbin. The branch looks good, let me check in the 2 changes I wanted to make and that should be it.

[landreev]

OK, I have checked in the json and ddi xml files. Will wait for Jenkins to do its thing and move into QA.

[mreekie]

sprint kickoff

• These are just waiting on jenkins tests to complete and QA

[landreev]

Moving into QA.

[kcondon]

Issues found:

1. Cannot add multiple series without error either to an existing or new dataset, see error in ui, none in logs but metadata is added. Can add a single series value without error. Maybe indexing?