Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiles pre 1900 #165

Open
bkatiemills opened this issue May 30, 2016 · 1 comment
Open

Profiles pre 1900 #165

bkatiemills opened this issue May 30, 2016 · 1 comment

Comments

@bkatiemills
Copy link
Member

Hi @castelao - CoTeDe tests are currently producing errors on profiles from years earlier than 1900:

ValueError: year=1773 is before 1900; the datetime strftime() methods require year >= 1900

before I go hacking on these, have you solved this previously for CoTeDe? Let me know if you have a preferred solution.
s-good added a commit that referenced this issue Aug 5, 2016
@s-good
Exclude profiles pre-1900
0c794c6 
As mentioned #165 CoTeDe uses a datetime function that cannot handle dates before 1900. This filters out those observations from being put in the database.

Alternative is to leave them in and exclude them from going through the quality control in AutoQC.py. However that could cause confusion later when analysing results and it is straightforward to add extra rows to the database at a later time if we want to process them.
@s-good s-good mentioned this issue Aug 5, 2016
Closed
@bkatiemills
Copy link
Member Author

At the moment when we find a profile pre 1900, we're just fudging the year to be 1900 and going ahead with running; remember to revert this when this gets fixed upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bkatiemills