Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError when running json2isatab, in investigation publications comments #116

Closed
djcomlab opened this issue Jul 4, 2016 · 1 comment
Closed

TypeError when running json2isatab, in investigation publications comments #116

djcomlab opened this issue Jul 4, 2016 · 1 comment
Assignees
@djcomlab
Labels
bug

Comments

@djcomlab
Copy link
Member

djcomlab commented Jul 4, 2016

(reported by COPO project)

Line 97 publications_df_cols.append('Comment[' + comment.name + ']') in isatab raises a TypeError

cannot concatenate a non-NDFrame object 'Comment[' + comment.name + ‘]'

when using json2isatab.

Is a problem building the column headers for the Comments in the dataframe.
@djcomlab djcomlab added the bug label Jul 4, 2016
@djcomlab djcomlab self-assigned this Jul 4, 2016
djcomlab added a commit that referenced this issue Jul 4, 2016
@djcomlab
Fix for bug reported in #116
b93fae6
@djcomlab
Copy link
Member Author

djcomlab commented Jul 6, 2016

Fixed in master and in latest tagged release (0.2.3).

@djcomlab djcomlab closed this as completed Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djcomlab djcomlab

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@djcomlab