Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the information source modal popup #97

Merged
merged 2 commits into from
May 20, 2020

Conversation

florianesser
Copy link
Member

  • show information source details if the proposal details view is in read-only mode
  • make sure that no editable controls are shown in the popup if proposal details view is in read-only mode

closes #95

Removes the unnecessary `!${isReadOnly}` check that prevents the modal body from
displaying when the viewed proposal is in read-only mode.

ISO-TC211#95
Makes sure that there are no editable input fields in the information source
modal popup when the details view is in read-only mode.

ISO-TC211#95
@florianesser florianesser requested a review from phuonghuynh May 19, 2020 21:06
Copy link
Contributor

@phuonghuynh phuonghuynh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phuonghuynh phuonghuynh merged commit fb41079 into ISO-TC211:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

500 error in Details action after acceptance of clarification by RM
2 participants