Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update traefik router hardcoded priorities #953

Conversation

YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Jan 30, 2025

What do these changes do?

  • Update traefik router hardcoded priorities according to the rules below
    • 1 --> 3
    • 2 --> 6
    • 3 --> 9
    • 10 --> 12
  • Remove unnecessary priority from adminpanels and registry service

This PR introduces some space in-between the routers which we can use to flexibly add new routers. It shouldn't break existing priority hierarchy since numbers <13 are still below any other non-hardcoded priorities.

Remarks for future:

  • Whenever introducing some priorities to traefik routers (or other similar cases) one better to make them spacious to retain flexibility. This case is a good example why "spacious" approach makes sense

Related issue/s

Related PR/s

Checklist

  • I tested and it works

@YuryHrytsuk YuryHrytsuk added the t:enhancement New feature or request label Jan 30, 2025
@YuryHrytsuk YuryHrytsuk added this to the Singularity milestone Jan 30, 2025
@YuryHrytsuk YuryHrytsuk self-assigned this Jan 30, 2025
@YuryHrytsuk YuryHrytsuk marked this pull request as ready for review January 30, 2025 08:52
@YuryHrytsuk YuryHrytsuk merged commit ff02387 into ITISFoundation:main Jan 30, 2025
3 checks passed
@mrnicegyu11
Copy link
Member

I agree w.r.t. making the space of traefik priorities spacious, look good from my side

mrnicegyu11 pushed a commit to mrnicegyu11/osparc-ops-environments that referenced this pull request Feb 3, 2025
* Update traefik router hardcoded priorities

* remove hardcoded priority from adminpanels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants