Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
adapt tests
Browse files Browse the repository at this point in the history
sanderegg committed Jan 22, 2024
1 parent 971ad63 commit 09ee122
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion services/clusters-keeper/tests/unit/conftest.py
Original file line number Diff line number Diff line change
@@ -101,6 +101,7 @@ def app_environment(
"CLUSTERS_KEEPER_EC2_SECRET_ACCESS_KEY": faker.pystr(),
"CLUSTERS_KEEPER_PRIMARY_EC2_INSTANCES": "{}",
"CLUSTERS_KEEPER_EC2_INSTANCES_PREFIX": faker.pystr(),
"CLUSTERS_KEEPER_DASK_NTHREADS": f"{faker.pyint(min_value=0)}",
"PRIMARY_EC2_INSTANCES_KEY_NAME": faker.pystr(),
"PRIMARY_EC2_INSTANCES_SECURITY_GROUP_IDS": json.dumps(
faker.pylist(allowed_types=(str,))
@@ -246,7 +247,7 @@ def clusters_keeper_docker_compose() -> dict[str, Any]:

@pytest.fixture
async def clusters_keeper_rabbitmq_rpc_client(
rabbitmq_rpc_client: Callable[[str], Awaitable[RabbitMQRPCClient]]
rabbitmq_rpc_client: Callable[[str], Awaitable[RabbitMQRPCClient]],
) -> RabbitMQRPCClient:
rpc_client = await rabbitmq_rpc_client("pytest_clusters_keeper_rpc_client")
assert rpc_client
2 changes: 1 addition & 1 deletion services/clusters-keeper/tests/unit/test_utils_clusters.py
Original file line number Diff line number Diff line change
@@ -97,7 +97,7 @@ def test_create_startup_script(
v[2:-1].split(":")[0]
for v in docker_compose_expected_environment.values()
if isinstance(v, str) and v.startswith("${")
] + ["DOCKER_IMAGE_TAG"]
] + ["DASK_NTHREADS", "DOCKER_IMAGE_TAG"]
for env_key in expected_env_keys:
assert (
env_key in startup_script_env_keys_names

0 comments on commit 09ee122

Please sign in to comment.