🐛 Fix webserver twilio env (#4566)

ITISFoundation · Aug 2, 2023 · 4faea96 · 4faea96
1 parent 2e33ecd
commit 4faea96
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/.env-devel b/.env-devel
@@ -158,6 +158,9 @@ LOGIN_REGISTRATION_CONFIRMATION_REQUIRED=0
 LOGIN_REGISTRATION_INVITATION_REQUIRED=0
 LOGIN_2FA_REQUIRED=0
 LOGIN_2FA_CODE_EXPIRATION_SEC=60
+TWILIO_ACCOUNT_SID=DUMMY
+TWILIO_AUTH_TOKEN=DUMMY
+TWILIO_COUNTRY_CODES_W_ALPHANUMERIC_SID_SUPPORT=["41"]
 
 WEBSERVER_FRONTEND={}
 

diff --git a/packages/settings-library/tests/test_twilio.py b/packages/settings-library/tests/test_twilio.py
@@ -2,8 +2,6 @@
 # pylint: disable=unused-argument
 # pylint: disable=unused-variable
 
-import pytest
-from pydantic import ValidationError
 from pytest import MonkeyPatch
 from pytest_simcore.helpers.utils_envs import setenvs_from_dict
 from settings_library.twilio import TwilioSettings
@@ -12,10 +10,6 @@
 def test_twilio_settings_within_envdevel(
     mock_env_devel_environment: dict[str, str], monkeypatch: MonkeyPatch
 ):
-    # in .env-devel these are for the oment undefined
-    with pytest.raises(ValidationError):
-        TwilioSettings.create_from_envs()
-
     # adds twilio credentials
     with monkeypatch.context() as patch:
         setenvs_from_dict(

diff --git a/services/docker-compose.yml b/services/docker-compose.yml
@@ -334,6 +334,9 @@ services:
       LOGIN_REGISTRATION_INVITATION_REQUIRED: ${LOGIN_REGISTRATION_INVITATION_REQUIRED}
       LOGIN_2FA_REQUIRED: ${LOGIN_2FA_REQUIRED}
       LOGIN_2FA_CODE_EXPIRATION_SEC: ${LOGIN_2FA_CODE_EXPIRATION_SEC}
+      TWILIO_ACCOUNT_SID: ${TWILIO_ACCOUNT_SID}
+      TWILIO_AUTH_TOKEN: ${TWILIO_AUTH_TOKEN}
+      TWILIO_COUNTRY_CODES_W_ALPHANUMERIC_SID_SUPPORT: ${TWILIO_COUNTRY_CODES_W_ALPHANUMERIC_SID_SUPPORT}
 
       # WEBSERVER_REDIS
       REDIS_HOST: ${REDIS_HOST}