Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoscaling: move retire_nodes call into the call to deactivate empty nodes #5867

Closed
sanderegg opened this issue May 23, 2024 · 1 comment
Closed

Autoscaling: move retire_nodes call into the call to deactivate empty nodes #5867

sanderegg opened this issue May 23, 2024 · 1 comment
Assignees
@sanderegg
Labels
a:autoscaling autoscaling service in simcore's stack a:dask-service Any of the dask services: dask-scheduler/sidecar or worker
Milestone
Eisbock

Comments

@sanderegg
Copy link
Member

Currently the call to retire nodes is made before _deactivate_empty_nodes.

Since we have now added a delay before draining, this might be inefficient to have retired the dask-workers and then wait 30 seconds before draining.

This needs a second thought and an implementation change maybe
@sanderegg sanderegg added a:autoscaling autoscaling service in simcore's stack a:dask-service Any of the dask services: dask-scheduler/sidecar or worker labels May 23, 2024
@sanderegg sanderegg self-assigned this May 23, 2024
@sanderegg sanderegg added this to the Eisbock milestone Sep 4, 2024
@sanderegg
Copy link
Member Author

fixed by #6345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanderegg sanderegg

Labels
a:autoscaling autoscaling service in simcore's stack a:dask-service Any of the dask services: dask-scheduler/sidecar or worker
Projects
None yet
Milestone
Eisbock
Development

No branches or pull requests
1 participant
@sanderegg