-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Autoscaling/Comp backend: drain retired nodes so that they can be re-used #6345
🐛Autoscaling/Comp backend: drain retired nodes so that they can be re-used #6345
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6345 +/- ##
=========================================
- Coverage 84.5% 64.5% -20.1%
=========================================
Files 10 591 +581
Lines 214 30224 +30010
Branches 25 260 +235
=========================================
+ Hits 181 19511 +19330
- Misses 23 10653 +10630
- Partials 10 60 +50
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What do these changes do?
Autoscaled Cluster was expanded to also keep retired_nodes.
These nodes were retired via dask scheduler mechanism, that removes idle workers and transfer their memory to other workers based on some internal mechanisms.
These "retired" workers are now properly recognized, and are forcefully drained. This way they can be:
Related issue/s
How to test
Dev-ops checklist