Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes rabbitmq config in server #1183

Merged
merged 4 commits into from
Nov 25, 2019
Merged

Fixes rabbitmq config in server #1183

merged 4 commits into from
Nov 25, 2019

Conversation

pcrespov
Copy link
Member

No description provided.

sanderegg
sanderegg approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks!

mguidon
mguidon approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like hot the M and the Q render now in the editor

Pedro Crespo added 2 commits November 25, 2019 13:12
Renamed RABBITMQ_ by RABBIT_
5cdc288 
Variables needs to be prefixed with service name in docker-compose
Updates utils to find published port
0f3a9c9 
Ensures environ variable exist before replacing them
@codecov-io
Copy link

codecov-io commented Nov 25, 2019 •
edited
Loading

Codecov Report

Merging #1183 into master will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1183      +/-   ##
==========================================
+ Coverage    70.3%   70.54%   +0.23%     
==========================================
  Files         143      135       -8     
  Lines        6281     5989     -292     
==========================================
- Hits         4416     4225     -191     
+ Misses       1865     1764     -101
Impacted Files Coverage Δ
api/tests/test_conventions_openapi.py
api/tests/test_repo_data.py
api/tests/test_individual_json_schemas.py
api/tests/conftest.py
api/tests/test_individual_openapi_schemas.py
api/tests/test_against_openapi_core.py
api/tests/test_full_openapis.py
api/tests/utils.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 771da8e...e763c42. Read the comment docs.

@pcrespov pcrespov merged commit b09308d into ITISFoundation:master Nov 25, 2019
@sanderegg sanderegg mentioned this pull request Nov 25, 2019
Merged
@pcrespov pcrespov deleted the fix/rabbit-config branch November 26, 2019 17:05
@pcrespov pcrespov restored the fix/rabbit-config branch December 2, 2019 13:54
@pcrespov pcrespov deleted the fix/rabbit-config branch December 2, 2019 13:54
jsaq007 added a commit to jsaq007/osparc-simcore that referenced this pull request Nov 20, 2023
@jsaq007
Read-only user cannot open the iframes ITISFoundation#1183
8bd6237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg approved these changes

@mguidon mguidon mguidon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcrespov @codecov-io @mguidon @sanderegg