-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds MPI scheduling support #1673
Adds MPI scheduling support #1673
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1673 +/- ##
========================================
- Coverage 73.6% 73.3% -0.4%
========================================
Files 278 279 +1
Lines 10923 11010 +87
Branches 1179 1189 +10
========================================
+ Hits 8050 8078 +28
- Misses 2530 2589 +59
Partials 343 343
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…rc-simcore-forked into adding-sidecar-mpi-scheduling
async-timeout==3.0.1 # via aiohttp | ||
attrs==19.3.0 # via aiohttp | ||
aioredis==1.3.1 # via aioredlock | ||
aioredlock==0.5.2 # via -r requirements/_base.in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm are you sure all these changes are needed? well not that I care too much but maybe for next time there is a way to only update the library you add doing something like:
make reqs update=NAMEOFLIBRARY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've actually added that library because I need it. Not happy about it, but the async version was the better one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get that, I am a bit astonished that so many changes come in which is why I thought you updated more than just the aioredlock. whatever that is minor and if it's green it's green!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is that this project is not covered by depbot, so when I've updated with these 2 libraries, all others got updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Sorry, I thought I already approved minus the wrong label in the sleeper.
adresses #1507 |
What do these changes do?
Allow the user to schedule services on MPI nodes. Please check proposed implementation in the liked issue.
Note: In development mode, the
sidecar_mpi
service will be spawned as an MPI node. This is done by setting theTARGET_MPI_NODE_CPU_COUNT
environment variable to the number of CPUs of the host.Related issue number
Closes #1672
How to test
Create a Study and add at least one copy of the following computational:
sidecar
,sidecar-gpu
andsidecar-mpi
.Press play and check the logs of the sidecar_mpi swarm service.
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)