Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix from staging: typo in git refs/heads (#1679) #1680

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 6, 2020

(cherry picked from commit fd14df5)

What do these changes do?

fix typo in github actions workflow file

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@sanderegg sanderegg added this to the Da Jia milestone Aug 6, 2020
@sanderegg sanderegg requested review from Surfict, GitHK and odeimaiz August 6, 2020 14:37
@sanderegg sanderegg self-assigned this Aug 6, 2020
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #1680 into master will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1680     +/-   ##
========================================
- Coverage    73.7%   73.6%   -0.1%     
========================================
  Files         278     278             
  Lines       10918   10918             
  Branches     1179    1179             
========================================
- Hits         8047    8046      -1     
- Misses       2528    2529      +1     
  Partials      343     343             
Flag Coverage Δ
#integrationtests 56.7% <ø> (ø)
#unittests 67.4% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ce_webserver/resource_manager/garbage_collector.py 72.0% <0.0%> (-2.2%) ⬇️
.../director/src/simcore_service_director/producer.py 63.0% <0.0%> (+0.2%) ⬆️

@sanderegg sanderegg merged commit 259e790 into ITISFoundation:master Aug 10, 2020
@sanderegg sanderegg deleted the hotfix/typo_in_release_workflow branch August 10, 2020 08:30
@sanderegg sanderegg mentioned this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants