Making services more debuggable

[GitHK]

What do these changes do?

• fixes an issue where retrieving logs from dead containers would cause the service scheduling to hang (a message will now be displayed in the service logs)
• before failing and stopping the service a message the error message will be posted to the service logs

Will help debugging #1479

Related issue number

How to test

Checklist

• Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
• Unit tests for the changes exist
• Runs in the swarm
• Documentation reflects the changes
• New module? Add your github username to .github/CODEOWNERS

[codecov]

Codecov Report

Merging #1690 into master will increase coverage by 0.0%.
The diff coverage is 50.0%.

@@          Coverage Diff           @@
##           master   #1690   +/-   ##
======================================
  Coverage    73.6%   73.7%           
======================================
  Files         278     278           
  Lines       10919   10923    +4     
  Branches     1179    1179           
======================================
+ Hits         8047    8051    +4     
- Misses       2529    2530    +1     
+ Partials      343     342    -1     

Flag	Coverage Δ
#integrationtests	56.7% <50.0%> (-0.1%)	⬇️
#unittests	67.4% <12.5%> (+<0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...es/sidecar/src/simcore_service_sidecar/executor.py	85.7% <0.0%> (ø)
.../sidecar/src/simcore_service_sidecar/log_parser.py	88.8% <66.6%> (-2.7%)	⬇️
.../director/src/simcore_service_director/producer.py	63.5% <0.0%> (+0.4%)	⬆️

[odeimaiz]

👍

[sanderegg]

just wondering, import aiodocker vs from aiodocker.exceptions import DockerError ? what are the implications? is there any typical python directive?

[GitHK]

there is no reason, but this way you know exactly from which module the error comes. It's more readable because sometimes you may have a GenericError and with this form except module.submodule.GenericError... is easier to read.