Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branding oSparc #1713

Merged
merged 11 commits into from
Aug 19, 2020
Merged

Branding oSparc #1713

merged 11 commits into from
Aug 19, 2020

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 18, 2020 •
edited
Loading

What do these changes do?

Brings more visibility to the current platform name. It also adds the "Z43" string if URL contains "speag".

  • Tab name
  • Logo in login page
  • Logo in navigation bar

Bonus

  • Link to Z43-manual

Tab
image

Login
image

NavBar
image

@odeimaiz odeimaiz changed the title Feature/branding osparc WIP: Branding oSparc Aug 18, 2020
@odeimaiz odeimaiz self-assigned this Aug 18, 2020
@odeimaiz odeimaiz marked this pull request as draft August 18, 2020 15:18
@codecov
Copy link

codecov bot commented Aug 18, 2020 •
edited
Loading

Codecov Report

Merging #1713 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1713   +/-   ##
======================================
  Coverage    72.4%   72.4%           
======================================
  Files         278     278           
  Lines       11229   11229           
  Branches     1240    1240           
======================================
  Hits         8132    8132           
  Misses       2763    2763           
  Partials      334     334
Flag Coverage Δ
#integrationtests 57.1% <ø> (ø)
#unittests 66.3% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odeimaiz odeimaiz added this to the Da Jia milestone Aug 18, 2020
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Aug 18, 2020
@odeimaiz odeimaiz marked this pull request as ready for review August 19, 2020 13:26
@odeimaiz odeimaiz changed the title WIP: Branding oSparc Branding oSparc Aug 19, 2020
mguidon
mguidon approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CARTUCHO

GitHK
GitHK approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great this looks nice

sanderegg
sanderegg approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazingly tremendous !

@odeimaiz odeimaiz merged commit 1402dc2 into ITISFoundation:master Aug 19, 2020
@sanderegg sanderegg mentioned this pull request Aug 21, 2020
Merged
@odeimaiz odeimaiz deleted the feature/branding-osparc branch November 26, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg approved these changes

@mguidon mguidon mguidon approved these changes

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov

@ignapas ignapas Awaiting requested review from ignapas

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
Da Jia
Development

Successfully merging this pull request may close these issues.
4 participants
@odeimaiz @GitHK @mguidon @sanderegg