-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serve group classifiers (Frontend) #1722
Serve group classifiers (Frontend) #1722
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1722 +/- ##
======================================
Coverage 72.4% 72.4%
======================================
Files 279 279
Lines 11263 11263
Branches 1240 1240
======================================
+ Hits 8158 8159 +1
+ Misses 2772 2771 -1
Partials 333 333
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@odeimaiz how do I test this? Can't figure out there format of the entry in the database. |
More on this. I manage to query via the API for the classifiers, but the frontend does no request to a /v0/groups/{GID}/classifiers endpoint. Is this correct? |
Frontend makes that call for all organizations you belong to. If you belong to 0 organizations, the frontend will make 0 calls |
…c-simcore into feature/fetch-classifiers
I see now, will fix this |
From what I can tell the gid in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the bundle is uploaded and associated with the correct group gid
it works as expected.
classifierPromises.push(osparc.data.Resources.get("classifiers", params)); | ||
}); | ||
Promise.all(classifierPromises) | ||
.then(classifierss => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MINOR: classifiersS<-- this is on purpose or a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On purpose. classifierss: list of classifiers
What do these changes do?
Provides frontend for #1719
Related issue number
How to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)