Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve group classifiers (Frontend) #1722

Merged
merged 35 commits into from
Aug 20, 2020

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 20, 2020

What do these changes do?

Provides frontend for #1719

image

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Aug 20, 2020
@odeimaiz odeimaiz added this to the Da Jia milestone Aug 20, 2020
@odeimaiz odeimaiz self-assigned this Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #1722 into master will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1722   +/-   ##
======================================
  Coverage    72.4%   72.4%           
======================================
  Files         279     279           
  Lines       11263   11263           
  Branches     1240    1240           
======================================
+ Hits         8158    8159    +1     
+ Misses       2772    2771    -1     
  Partials      333     333           
Flag Coverage Δ
#integrationtests 57.1% <ø> (ø)
#unittests 66.3% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../director/src/simcore_service_director/producer.py 58.7% <0.0%> (+0.2%) ⬆️

@odeimaiz odeimaiz marked this pull request as ready for review August 20, 2020 09:47
@GitHK
Copy link
Contributor

GitHK commented Aug 20, 2020

@odeimaiz how do I test this? Can't figure out there format of the entry in the database.

@GitHK
Copy link
Contributor

GitHK commented Aug 20, 2020

@odeimaiz how do I test this? Can't figure out there format of the entry in the database.

More on this. I manage to query via the API for the classifiers, but the frontend does no request to a /v0/groups/{GID}/classifiers endpoint. Is this correct?

@odeimaiz
Copy link
Member Author

odeimaiz commented Aug 20, 2020

@odeimaiz how do I test this? Can't figure out there format of the entry in the database.

More on this. I manage to query via the API for the classifiers, but the frontend does no request to a /v0/groups/{GID}/classifiers endpoint. Is this correct?

Frontend makes that call for all organizations you belong to. If you belong to 0 organizations, the frontend will make 0 calls

@GitHK
Copy link
Contributor

GitHK commented Aug 20, 2020

@odeimaiz how do I test this? Can't figure out there format of the entry in the database.

More on this. I manage to query via the API for the classifiers, but the frontend does no request to a /v0/groups/{GID}/classifiers endpoint. Is this correct?

Frontend makes that call for all organizations you belong to. If you belong to 0 organizations, the frontend will make 0 calls

I see now, will fix this

@GitHK
Copy link
Contributor

GitHK commented Aug 20, 2020

@odeimaiz how do I test this? Can't figure out there format of the entry in the database.

More on this. I manage to query via the API for the classifiers, but the frontend does no request to a /v0/groups/{GID}/classifiers endpoint. Is this correct?

Frontend makes that call for all organizations you belong to. If you belong to 0 organizations, the frontend will make 0 calls

I see now, will fix this

From what I can tell the gid in the group_classifiers table must be the gid of the organization!

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the bundle is uploaded and associated with the correct group gid it works as expected.

classifierPromises.push(osparc.data.Resources.get("classifiers", params));
});
Promise.all(classifierPromises)
.then(classifierss => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR: classifiersS<-- this is on purpose or a typo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On purpose. classifierss: list of classifiers

@pcrespov pcrespov merged commit adc6ad8 into ITISFoundation:master Aug 20, 2020
@sanderegg sanderegg mentioned this pull request Aug 21, 2020
@odeimaiz odeimaiz deleted the feature/fetch-classifiers branch November 26, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants