Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues with nvidia-smi containers having the same name #1727

Merged
merged 2 commits into from
Aug 21, 2020

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Aug 21, 2020

What do these changes do?

When multiple sidecars are assigned to the same node and they all try to run is_gpu_node they will all get the same pid thus failing to start the container.
The changes avoid this and fixe the behaviour.

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #1727 into master will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1727     +/-   ##
========================================
- Coverage    72.5%   72.4%   -0.1%     
========================================
  Files         279     279             
  Lines       11267   11267             
  Branches     1238    1238             
========================================
- Hits         8173    8167      -6     
- Misses       2757    2764      +7     
+ Partials      337     336      -1     
Flag Coverage Δ
#integrationtests 57.1% <100.0%> (ø)
#unittests 66.4% <100.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...vices/sidecar/src/simcore_service_sidecar/utils.py 90.1% <100.0%> (ø)
...ce_webserver/resource_manager/garbage_collector.py 66.0% <0.0%> (-3.5%) ⬇️
.../simcore_service_webserver/projects/projects_db.py 82.3% <0.0%> (-1.1%) ⬇️
.../director/src/simcore_service_director/producer.py 60.1% <0.0%> (+0.2%) ⬆️

@GitHK GitHK added a:sidecar issue related with the sidecar worker service bug buggy, it does not work as expected labels Aug 21, 2020
@GitHK GitHK added this to the Da Jia milestone Aug 21, 2020
@GitHK GitHK self-assigned this Aug 21, 2020
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@GitHK GitHK merged commit 184ae08 into ITISFoundation:master Aug 21, 2020
@sanderegg sanderegg mentioned this pull request Aug 21, 2020
@GitHK GitHK mentioned this pull request Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:sidecar issue related with the sidecar worker service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants