Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ✨ Is353/computational function services #2903

Conversation

pcrespov
Copy link
Member

What do these changes do?

Builds up on new concept of "function service" developed in PR #2756 and implements the possibility to have function services running in the computational backend.

Related issue/s

How to test

  • Covered by CI

Checklist

@pcrespov pcrespov self-assigned this Mar 17, 2022
@pcrespov pcrespov added this to the E.Shackleton milestone Mar 17, 2022
@pcrespov pcrespov force-pushed the is353/computational-function-services branch from 711bd41 to 642333e Compare March 24, 2022 01:22
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #2903 (3df45db) into master (7ae21de) will decrease coverage by 0.1%.
The diff coverage is 71.4%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2903     +/-   ##
========================================
- Coverage    79.0%   78.9%   -0.2%     
========================================
  Files         677     665     -12     
  Lines       28228   27576    -652     
  Branches     3282    3214     -68     
========================================
- Hits        22315   21764    -551     
+ Misses       5133    5071     -62     
+ Partials      780     741     -39     
Flag Coverage Δ
integrationtests 64.1% <71.4%> (-1.7%) ⬇️
unittests 74.7% <71.4%> (+0.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rector_v2/modules/comp_scheduler/base_scheduler.py 86.7% <ø> (ø)
...rector_v2/modules/comp_scheduler/dask_scheduler.py 89.6% <ø> (ø)
...simcore_service_director_v2/modules/dask_client.py 91.7% <ø> (ø)
...ector_v2/modules/comp_scheduler/background_task.py 83.3% <66.6%> (-8.4%) ⬇️
...ice_director_v2/modules/comp_scheduler/_factory.py 100.0% <100.0%> (ø)
...simcore_service_webserver/computation_subscribe.py 27.0% <0.0%> (-61.0%) ⬇️
.../simcore_service_webserver/computation_settings.py 55.5% <0.0%> (-44.5%) ⬇️
...erver/src/simcore_service_webserver/computation.py 75.0% <0.0%> (-25.0%) ⬇️
...webserver/computation_comp_tasks_listening_task.py 67.3% <0.0%> (-10.0%) ⬇️
... and 27 more

@pcrespov pcrespov force-pushed the is353/computational-function-services branch 2 times, most recently from cbeb4ae to 1e98da6 Compare March 29, 2022 20:13
@pcrespov pcrespov force-pushed the is353/computational-function-services branch from 1e98da6 to 3df45db Compare March 29, 2022 20:13
@pcrespov
Copy link
Member Author

pcrespov commented Apr 7, 2022

Will not use this approach. Replace instead by PR #2943

@pcrespov pcrespov closed this Apr 7, 2022
@pcrespov pcrespov deleted the is353/computational-function-services branch June 22, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant