Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Pipeline failure to port #3028

Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented May 9, 2022

What do these changes do?

  • Show node error on hovering failed chip
  • If error is thrown by a port, show it in its tooltip

error_in_tooltip

Related issue/s

related to ITISFoundation/osparc-issues#516

How to test

Checklist

@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label May 9, 2022
@odeimaiz odeimaiz added this to the Macarons +1 milestone May 9, 2022
@odeimaiz odeimaiz self-assigned this May 9, 2022
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #3028 (8d95693) into master (cd864d3) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3028     +/-   ##
========================================
- Coverage    79.7%   79.7%   -0.1%     
========================================
  Files         698     698             
  Lines       29245   29245             
  Branches     3761    3761             
========================================
- Hits        23324   23319      -5     
  Misses       5081    5081             
- Partials      840     845      +5     
Flag Coverage Δ
integrationtests 66.0% <ø> (+0.1%) ⬆️
unittests 75.4% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ector_v2/modules/comp_scheduler/background_task.py 83.3% <0.0%> (-8.4%) ⬇️
...ore_service_director_v2/utils/client_decorators.py 73.3% <0.0%> (-3.4%) ⬇️
...mcore_service_webserver/garbage_collector_utils.py 79.4% <0.0%> (-3.0%) ⬇️
...rector_v2/modules/comp_scheduler/base_scheduler.py 86.7% <0.0%> (-1.9%) ⬇️
...e_service_director_v2/modules/dask_clients_pool.py 92.7% <0.0%> (-1.5%) ⬇️
.../director/src/simcore_service_director/producer.py 61.6% <0.0%> (-0.7%) ⬇️
...simcore_service_director_v2/modules/dask_client.py 91.9% <0.0%> (-0.7%) ⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 81.9% <0.0%> (ø)
..._director_v2/modules/dynamic_sidecar/docker_api.py 88.0% <0.0%> (+0.8%) ⬆️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 91.2% <0.0%> (+1.0%) ⬆️
... and 1 more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odeimaiz odeimaiz marked this pull request as ready for review May 10, 2022 14:01
@odeimaiz odeimaiz changed the title ✨WIP: Pipeline failure to port ✨Pipeline failure to port May 10, 2022
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gorgeous

@odeimaiz odeimaiz merged commit ef38c09 into ITISFoundation:master May 11, 2022
@odeimaiz odeimaiz deleted the feature/pipeline-failure-to-port branch August 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants